Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 23522022: Revert "Fix multiple V8::Dispose calls since r16563." and disable test. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger
Modified:
7 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Revert "Fix multiple V8::Dispose calls since r16563." and disable test. TBR=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16569

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M src/isolate.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/v8.cc View 3 chunks +2 lines, -12 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 3 months ago (2013-09-06 11:22:53 UTC) #1
Jakob Kummerow
rubberstamp LGTM.
7 years, 3 months ago (2013-09-06 11:23:43 UTC) #2
Michael Starzinger
7 years, 3 months ago (2013-09-06 11:24:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16569 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698