Issue 23522006: Revert "ConstantPoolSizeAt() should return number of Instructions instead, otherwise, some of the c…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23522006: Revert "ConstantPoolSizeAt() should return number of Instructions instead, otherwise, some of the c… (Closed)

Created:
7 years, 3 months ago by Jakob Kummerow

Modified:
7 years, 3 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev, Bangfu

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "ConstantPoolSizeAt() should return number of Instructions instead, otherwise, some of the code will be treated as constant pool when printing code in ARM disassembler." This reverts commit r16419 for breaking ARM Debug tests. Using https://codereview.chromium.org/23531013/ instead.

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/arm/disasm-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Benedikt: PTAL.

Bangfu: FYI.

Expand Messages | Collapse Messages