Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issue 23522003: Drop unused and undocumented dummy_ from SaveContext. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Drop unused and undocumented dummy_ from SaveContext. Also remove the obsolte __GNUC_VERSION__ #define. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M src/isolate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/isolate-inl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/platform.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Hey Sven, This is the weird dummy_ thing we're talking about. -- Benedikt
7 years, 3 months ago (2013-08-28 09:01:13 UTC) #1
Sven Panne
LGTM. If it breaks for some weird reason, we will at least learn something. :-)
7 years, 3 months ago (2013-08-28 09:32:52 UTC) #2
Benedikt Meurer
7 years, 3 months ago (2013-08-28 09:40:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16385.

Powered by Google App Engine
This is Rietveld 408576698