Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2352183002: Revert of Updating swarming api to check for chartjson results from a finished (Closed)

Created:
4 years, 3 months ago by jbudorick
Modified:
4 years, 3 months ago
CC:
chromium-reviews, Dirk Pranke, dtu, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, M-A Ruel, Vadim Sh.
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Updating swarming api to check for chartjson results from a finished (patchset #10 id:180001 of https://codereview.chromium.org/2336293002/ ) Reason for revert: I think this might have broken telemetry_perf_unittests on linux_android_rel_ng (at least). Original issue's description: > Updating swarming api to add chartjson output. > > This updates the api to check for chartjson results from a finished task in output directory with a file named chart-output.json. > > BUG=chromium:633253 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/99542aa3517f274e8f444dd39290102fd75a2206 TBR=phajdan.jr@chromium.org,dpranke@chromium.org,kbr@chromium.org,eyaich@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:633253 Committed: https://chromium.googlesource.com/chromium/tools/build/+/33c0f7e68cf58c10f2877e834fc16c6a5754dab9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1102 lines) Patch
M scripts/slave/recipe_modules/swarming/api.py View 5 chunks +12 lines, -70 lines 0 comments Download
M scripts/slave/recipe_modules/test_utils/test_api.py View 3 chunks +9 lines, -30 lines 0 comments Download
M scripts/slave/recipes/chromium.py View 2 chunks +1 line, -73 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json View 2 chunks +2 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_gpu.json View 3 chunks +3 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test_with_swarming_failure.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json View 1 chunk +1 line, -2 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json View 1 chunk +0 lines, -452 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json View 1 chunk +0 lines, -443 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_missing_shard.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_test.json View 2 chunks +1 line, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jbudorick
Created Revert of Updating swarming api to check for chartjson results from a finished
4 years, 3 months ago (2016-09-20 19:55:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352183002/1
4 years, 3 months ago (2016-09-20 19:55:27 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 19:55:39 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/33c0f7e68cf58c10f287...

Powered by Google App Engine
This is Rietveld 408576698