Mojoify FetchEvent of Service Worker.

content/browser/service_worker/service_worker_fetch_dispatcher.cc

Index: content/browser/service_worker/service_worker_fetch_dispatcher.cc
diff --git a/content/browser/service_worker/service_worker_fetch_dispatcher.cc b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
index 130d87c4e15f8b1fab07bfbf864dd5c48b7a64df..e0277db53b185201e8db8c39e7082b2b4ac3e740 100644
--- a/content/browser/service_worker/service_worker_fetch_dispatcher.cc
+++ b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
@@ -12,6 +12,7 @@
 #include "base/trace_event/trace_event.h"
 #include "content/browser/service_worker/embedded_worker_status.h"
 #include "content/browser/service_worker/service_worker_version.h"
+#include "content/common/service_worker/fetch_event_dispatcher.mojom.h"
 #include "content/common/service_worker/service_worker_messages.h"
 #include "content/common/service_worker/service_worker_utils.h"
 #include "net/log/net_log_event_type.h"
@@ -71,6 +72,16 @@ ServiceWorkerMetrics::EventType FetchTypeToWaitUntilEventType(
   return ServiceWorkerMetrics::EventType::FETCH_WAITUNTIL;
 }
 
+void OnFetchEventFinished(scoped_refptr<ServiceWorkerVersion> active_version,

[shimazu, 2016/09/23 03:26:11]

If I understand correctly, I'm worried that this scoped_refptr<> could make a
cyclic reference as below:
version -(owns)-> dispatcher -(owns)-> callback -(retains)-> version

I think this callback won't be called after SWVersion is destructed, so it's
okay to have a raw pointer, or WeakPtr might be fine.

WDYT?

[horo, 2016/09/23 05:57:56]

Done.

+                          int event_finish_id,
+                          blink::mojom::ServiceWorkerEventStatus status,
+                          base::Time dispatch_event_time) {
+  active_version->FinishRequest(
+      event_finish_id,
+      status == blink::mojom::ServiceWorkerEventStatus::COMPLETED,
+      dispatch_event_time);
+}
+
 }  // namespace
 
 // Helper to receive the fetch event response even if
@@ -208,11 +219,13 @@ void ServiceWorkerFetchDispatcher::DispatchFetchEvent() {
       response_id,
       base::Bind(&ServiceWorkerFetchDispatcher::ResponseCallback::Run,
                  base::Owned(response_callback)));
-  version_->RegisterSimpleRequest<ServiceWorkerHostMsg_FetchEventFinished>(
-      event_finish_id);
-  version_->DispatchEvent({response_id, event_finish_id},
-                          ServiceWorkerMsg_FetchEvent(
-                              response_id, event_finish_id, *request_.get()));
+
+  base::WeakPtr<mojom::FetchEventDispatcher> dispatcher =
+      version_->GetMojoServiceForRequest<mojom::FetchEventDispatcher>(
+          event_finish_id);
+  dispatcher->DispatchFetchEvent(
+      response_id, *request_.get(),
+      base::Bind(&OnFetchEventFinished, version_, event_finish_id));
 }
 
 void ServiceWorkerFetchDispatcher::DidFailToDispatch(