content/common/service_worker/fetch_event_dispatcher.mojom - Issue 2352173004: Mojoify FetchEvent of Service Worker.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/service_worker/fetch_event_dispatcher.mojom

Issue 2352173004: Mojoify FetchEvent of Service Worker. (Closed)

Patch Set: rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/service_worker/service_worker_fetch_dispatcher.cc ('K') | « content/common/BUILD.gn ('k') | content/common/service_worker/fetch_event_dispatcher.typemap » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module content.mojom;

	6

	7 import "mojo/common/common_custom_types.mojom";

	8 import "third_party/WebKit/public/platform/modules/serviceworker/service_worker_ event_status.mojom";

	9

	10 [Native]

	11 struct ServiceWorkerFetchRequest;

	12

	13 interface FetchEventDispatcher {
	dcheng 2016/09/30 08:54:43 Is there an overall design doc of how SW will work Is there an overall design doc of how SW will work in Mojo? This seems like a very small interface, and I'm wondering if it would make more sense as part of a larger SW interface? horo 2016/10/03 02:30:57 shimazu@ is working on the Mojofication of SW. BUG Show quoted text On 2016/09/30 08:54:43, dcheng wrote: > Is there an overall design doc of how SW will work in Mojo? This seems like a > very small interface, and I'm wondering if it would make more sense as part of a > larger SW interface? shimazu@ is working on the Mojofication of SW. BUG: https://crbug.com/629701 design doc: https://docs.google.com/document/d/1DwPpvZG1gTCk5JAULmjPf0eCOHt01Pk59YdwRrbQW... We don't think we can mojofy all SW events so quickly. But the priority of "navigation preload" which needs Mojo is high. (We will use Mojo's datapipe to pass the preloaded response to the SW.) So we want to mojofy FetchEvent before mojofying all SW events. SyncEvent has been already mojofied (crbug.com/479251) So this CL is using the similar approach.
	14 DispatchFetchEvent(int32 response_id, ServiceWorkerFetchRequest request)

	15 => (blink.mojom.ServiceWorkerEventStatus status,

	16 mojo.common.mojom.Time dispatch_event_time);

	17 };

OLD	NEW