[gn] Add gn support to gcmole

[gn] Add gn support to gcmole

This also adds sources missing for PPC and x87, fixes a few
missing files in gyp due to wrong quotation and a few that
were simply not included.

The gn files are now authoritative, but the gcmole gyp and
gn source lists are enforced to match exactly.

This additional enforcement helped finding the bugs above
and will be removed when we deprecate the gyp files.

BUG=chromium:614645
NOTRY=true

Committed: https://crrev.com/a8951a96ab4474f57240844e24f1779601bd05cd
Cr-Commit-Position: refs/heads/master@{#39592}

[Michael Achenbach, 2016-09-21 10:39:15]

Description was changed from

==========
[gn] Add gn support to gcmole

BUG=
==========

to

==========
[gn] Add gn support to gcmole

This also adds sources missing for PPC and x87, fixes a few
missing gyp files due to wrong quotation and a few that
where simply not included.

The gn files are now authoritative, but the gcmole gyp and
gn source lists are enforced to match exactly.

This additional enforcement helped finding a the bugs above
and will be removed when we deprecate the gyp files.

BUG=614645
==========

[Michael Achenbach, 2016-09-21 10:39:43]

Description was changed from

==========
[gn] Add gn support to gcmole

This also adds sources missing for PPC and x87, fixes a few
missing gyp files due to wrong quotation and a few that
where simply not included.

The gn files are now authoritative, but the gcmole gyp and
gn source lists are enforced to match exactly.

This additional enforcement helped finding a the bugs above
and will be removed when we deprecate the gyp files.

BUG=614645
==========

to

==========
[gn] Add gn support to gcmole

This also adds sources missing for PPC and x87, fixes a few
missing files in gyp due to wrong quotation and a few that
were simply not included.

The gn files are now authoritative, but the gcmole gyp and
gn source lists are enforced to match exactly.

This additional enforcement helped finding a the bugs above
and will be removed when we deprecate the gyp files.

BUG=614645
==========

[Michael Achenbach, 2016-09-21 10:46:13]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org, mstarzinger@chromium.org

[Michael Achenbach, 2016-09-21 11:11:19]

PTAL

https://codereview.chromium.org/2352103002/diff/140001/src/v8.gyp
File src/v8.gyp (right):

https://codereview.chromium.org/2352103002/diff/140001/src/v8.gyp#newcode585
src/v8.gyp:585: 'compiler/escape-analysis-reducer.cc',
I tried to make the regexp for gyp more forgiving, but it's not that simple as
lua's regexp language is very limited. So keeping it as it is for the time being
and fixing the quotations.

https://codereview.chromium.org/2352103002/diff/140001/tools/gcmole/gcmole.lua
File tools/gcmole/gcmole.lua (right):

https://codereview.chromium.org/2352103002/diff/140001/tools/gcmole/gcmole.lu...
tools/gcmole/gcmole.lua:212: local function ParseGNFile()
c:p of the function above with modifications. The one above will get removed
soonish - so no need to share code.

https://codereview.chromium.org/2352103002/diff/140001/tools/gcmole/gcmole.lu...
tools/gcmole/gcmole.lua:283: 
The outcome of this comparison can be seen in patchsets 2-6. I think I ran into
each corner case above and fixed the problems successively.

[Michael Achenbach, 2016-09-21 11:11:50]

Description was changed from

==========
[gn] Add gn support to gcmole

This also adds sources missing for PPC and x87, fixes a few
missing files in gyp due to wrong quotation and a few that
were simply not included.

The gn files are now authoritative, but the gcmole gyp and
gn source lists are enforced to match exactly.

This additional enforcement helped finding a the bugs above
and will be removed when we deprecate the gyp files.

BUG=614645
==========

to

==========
[gn] Add gn support to gcmole

This also adds sources missing for PPC and x87, fixes a few
missing files in gyp due to wrong quotation and a few that
were simply not included.

The gn files are now authoritative, but the gcmole gyp and
gn source lists are enforced to match exactly.

This additional enforcement helped finding the bugs above
and will be removed when we deprecate the gyp files.

BUG=614645
==========

[Michael Achenbach, 2016-09-21 11:13:03]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 11:13:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2016-09-21 11:24:48]

LGTM.

https://codereview.chromium.org/2352103002/diff/140001/src/v8.gyp
File src/v8.gyp (right):

https://codereview.chromium.org/2352103002/diff/140001/src/v8.gyp#newcode585
src/v8.gyp:585: 'compiler/escape-analysis-reducer.cc',
On 2016/09/21 11:11:19, machenbach (slow) wrote:
> I tried to make the regexp for gyp more forgiving, but it's not that simple as
> lua's regexp language is very limited. So keeping it as it is for the time
being
> and fixing the quotations.

Acknowledged.

https://codereview.chromium.org/2352103002/diff/140001/tools/gcmole/gcmole.lua
File tools/gcmole/gcmole.lua (right):

https://codereview.chromium.org/2352103002/diff/140001/tools/gcmole/gcmole.lu...
tools/gcmole/gcmole.lua:186: local function ParseGYPFile()
nit: Lets also add a TODO here that this will be removed when deprecating GYP.

https://codereview.chromium.org/2352103002/diff/140001/tools/gcmole/gcmole.lu...
tools/gcmole/gcmole.lua:212: local function ParseGNFile()
On 2016/09/21 11:11:19, machenbach (slow) wrote:
> c:p of the function above with modifications. The one above will get removed
> soonish - so no need to share code.

Acknowledged.

https://codereview.chromium.org/2352103002/diff/140001/tools/gcmole/gcmole.lu...
tools/gcmole/gcmole.lua:283: 
On 2016/09/21 11:11:19, machenbach (slow) wrote:
> The outcome of this comparison can be seen in patchsets 2-6. I think I ran
into
> each corner case above and fixed the problems successively.

Acknowledged. Thanks!

[Michael Achenbach, 2016-09-21 11:40:56]

Done - setting notry now to commit the last patchset

https://codereview.chromium.org/2352103002/diff/140001/tools/gcmole/gcmole.lua
File tools/gcmole/gcmole.lua (right):

https://codereview.chromium.org/2352103002/diff/140001/tools/gcmole/gcmole.lu...
tools/gcmole/gcmole.lua:186: local function ParseGYPFile()
On 2016/09/21 11:24:48, Michael Starzinger wrote:
> nit: Lets also add a TODO here that this will be removed when deprecating GYP.

Done in patch 9. Though, any attempt to remove our gyp files will break this
code anyways and naturally lead the developer here :)

[Michael Achenbach, 2016-09-21 11:41:19]

Description was changed from

==========
[gn] Add gn support to gcmole

This also adds sources missing for PPC and x87, fixes a few
missing files in gyp due to wrong quotation and a few that
were simply not included.

The gn files are now authoritative, but the gcmole gyp and
gn source lists are enforced to match exactly.

This additional enforcement helped finding the bugs above
and will be removed when we deprecate the gyp files.

BUG=614645
==========

to

==========
[gn] Add gn support to gcmole

This also adds sources missing for PPC and x87, fixes a few
missing files in gyp due to wrong quotation and a few that
were simply not included.

The gn files are now authoritative, but the gcmole gyp and
gn source lists are enforced to match exactly.

This additional enforcement helped finding the bugs above
and will be removed when we deprecate the gyp files.

BUG=614645
NOTRY=true
==========

[Michael Achenbach, 2016-09-21 11:41:52]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2016-09-21 11:41:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2352103002/#ps160001
(title: "Added todo")

[commit-bot: I haz the power, 2016-09-21 11:41:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 11:44:16]

Description was changed from

==========
[gn] Add gn support to gcmole

This also adds sources missing for PPC and x87, fixes a few
missing files in gyp due to wrong quotation and a few that
were simply not included.

The gn files are now authoritative, but the gcmole gyp and
gn source lists are enforced to match exactly.

This additional enforcement helped finding the bugs above
and will be removed when we deprecate the gyp files.

BUG=614645
NOTRY=true
==========

to

==========
[gn] Add gn support to gcmole

This also adds sources missing for PPC and x87, fixes a few
missing files in gyp due to wrong quotation and a few that
were simply not included.

The gn files are now authoritative, but the gcmole gyp and
gn source lists are enforced to match exactly.

This additional enforcement helped finding the bugs above
and will be removed when we deprecate the gyp files.

BUG=614645
NOTRY=true
==========

[commit-bot: I haz the power, 2016-09-21 11:44:17]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-09-21 11:45:31]

Description was changed from

==========
[gn] Add gn support to gcmole

This also adds sources missing for PPC and x87, fixes a few
missing files in gyp due to wrong quotation and a few that
were simply not included.

The gn files are now authoritative, but the gcmole gyp and
gn source lists are enforced to match exactly.

This additional enforcement helped finding the bugs above
and will be removed when we deprecate the gyp files.

BUG=614645
NOTRY=true
==========

to

==========
[gn] Add gn support to gcmole

This also adds sources missing for PPC and x87, fixes a few
missing files in gyp due to wrong quotation and a few that
were simply not included.

The gn files are now authoritative, but the gcmole gyp and
gn source lists are enforced to match exactly.

This additional enforcement helped finding the bugs above
and will be removed when we deprecate the gyp files.

BUG=614645
NOTRY=true

Committed: https://crrev.com/a8951a96ab4474f57240844e24f1779601bd05cd
Cr-Commit-Position: refs/heads/master@{#39592}
==========

[commit-bot: I haz the power, 2016-09-21 11:45:33]

Patchset 9 (id:??) landed as
https://crrev.com/a8951a96ab4474f57240844e24f1779601bd05cd
Cr-Commit-Position: refs/heads/master@{#39592}

[Michael Achenbach, 2016-09-21 11:51:15]

Description was changed from

==========
[gn] Add gn support to gcmole

This also adds sources missing for PPC and x87, fixes a few
missing files in gyp due to wrong quotation and a few that
were simply not included.

The gn files are now authoritative, but the gcmole gyp and
gn source lists are enforced to match exactly.

This additional enforcement helped finding the bugs above
and will be removed when we deprecate the gyp files.

BUG=614645
NOTRY=true

Committed: https://crrev.com/a8951a96ab4474f57240844e24f1779601bd05cd
Cr-Commit-Position: refs/heads/master@{#39592}
==========

to

==========
[gn] Add gn support to gcmole

This also adds sources missing for PPC and x87, fixes a few
missing files in gyp due to wrong quotation and a few that
were simply not included.

The gn files are now authoritative, but the gcmole gyp and
gn source lists are enforced to match exactly.

This additional enforcement helped finding the bugs above
and will be removed when we deprecate the gyp files.

BUG=chromium:614645
NOTRY=true

Committed: https://crrev.com/a8951a96ab4474f57240844e24f1779601bd05cd
Cr-Commit-Position: refs/heads/master@{#39592}
==========