Rework garden-o-matic to fetch lists of builds from googlestorage properly.

Tools/GardeningServer/scripts/results.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 11 matching lines @@
  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 var results = results || {};
 
 (function() {
 
 var kResultsName = 'failing_results.json';
 
-var kBuildLinkRegexp = /a href="\d+\/"/g;
-var kBuildNumberRegexp = /\d+/;
-
 var PASS = 'PASS';
 var TIMEOUT = 'TIMEOUT';
 var TEXT = 'TEXT';
 var CRASH = 'CRASH';
 var IMAGE = 'IMAGE';
 var IMAGE_TEXT = 'IMAGE+TEXT';
 var AUDIO = 'AUDIO';
 var MISSING = 'MISSING';
 
 var kFailingResults = [TEXT, IMAGE_TEXT, AUDIO];
@@ skipping 137 matching lines @@
 
 results.directoryForBuilder = function(builderName)
 {
     return config.kPlatforms[config.currentPlatform].resultsDirectoryNameFromBuilderName(builderName);
 }
 
 function resultsDirectoryURL(platform, builderName)
 {
     if (config.useLocalResults)
         return '/localresult?path=';
-    return resultsDirectoryListingURL(platform, builderName) + 'results/layout-test-results/';
+    return layoutTestResultsURL(platform) + '/' + results.directoryForBuilder(builderName) + '/results/layout-test-results/';
 }
 
-function resultsDirectoryListingURL(platform, builderName)
+function resultsPrefixListingURL(platform, builderName)
 {
-    return layoutTestResultsURL(platform) + '/' + results.directoryForBuilder(builderName) + '/';
+    return layoutTestResultsURL(platform) + '/?prefix=' + results.directoryForBuilder(builderName) + '/&delimiter=/';
 }
 
 function resultsDirectoryURLForBuildNumber(platform, builderName, buildNumber)
 {
-    return resultsDirectoryListingURL(platform, builderName) + buildNumber + '/';
+    return layoutTestResultsURL(platform) + '/' + results.directoryForBuilder(builderName) + '/' + buildNumber + '/' ;
 }
 
 function resultsSummaryURL(platform, builderName)
 {
     return resultsDirectoryURL(platform, builderName) + kResultsName;
 }
 
 function resultsSummaryURLForBuildNumber(platform, builderName, buildNumber)
 {
     return resultsDirectoryURLForBuildNumber(platform, builderName, buildNumber) + kResultsName;
@@ skipping 112 matching lines @@
     $.each(dictionaryOfResultNodes, function(key, resultNode) {
         var analyzer = new results.ResultAnalyzer(resultNode);
         collectedResults = collectedResults.concat(analyzer.unexpectedResults());
     });
     return base.uniquifyArray(collectedResults);
 };
 
 // Callback data is [{ buildNumber:, url: }]
 function historicalResultsLocations(platform, builderName, callback)
 {
-    var listingURL = resultsDirectoryListingURL(platform, builderName);
-    net.get(listingURL, function(directoryListing) {
-        var historicalResultsData = directoryListing.match(kBuildLinkRegexp).map(function(buildLink) {
-            var buildNumber = parseInt(buildLink.match(kBuildNumberRegexp)[0]);
-            var resultsData = {
-                'buildNumber': buildNumber,
-                'url': resultsSummaryURLForBuildNumber(platform, builderName, buildNumber)
-            };
-            return resultsData;
-        }).reverse();
-
+    var listingURL = resultsPrefixListingURL(platform, builderName);
+    net.get(listingURL, function(prefixListingDocument) {
+        var historicalResultsData = [];
+        $(prefixListingDocument).find("Prefix").each(function() {
+            var buildString = this.textContent.replace(results.directoryForBuilder(builderName) + '/', '');
+            if (buildString.match(/\d+\//)) {
+                var buildNumber = parseInt(buildString);
+                var resultsData = {
+                    'buildNumber': buildNumber,
+                    'url': resultsSummaryURLForBuildNumber(platform, builderName, buildNumber)
+                };
+                historicalResultsData.unshift(resultsData);
+           }
+        });
         callback(historicalResultsData);
     });
 }
 
 function walkHistory(platform, builderName, testName, callback)
 {
     var indexOfNextKeyToFetch = 0;
     var keyList = [];
 
     function continueWalk()
@@ skipping 185 matching lines @@
     $.each(builderNameList, function(index, builderName) {
         var resultsURL = resultsSummaryURL(config.currentPlatform, builderName);
         net.jsonp(resultsURL, function(resultsTree) {
             resultsByBuilder[builderName] = resultsTree;
             tracker.requestComplete();
         });
     });
 };
 
 })();