content/public/browser/web_contents_delegate.h - Issue 2352083003: Allow top-level navigation in extension pop-ups if it only triggers a download.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_contents_delegate.h

Issue 2352083003: Allow top-level navigation in extension pop-ups if it only triggers a download. (Closed)

Patch Set: Changed bug reference (in a TODO comment) to a fresh bug. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/web_contents_delegate.h

diff --git a/content/public/browser/web_contents_delegate.h b/content/public/browser/web_contents_delegate.h

index b7d17d294e0b56b8f18bba5df9fe567d5042fe78..c17ff83c8104dbf0de3bc343a81c89ba7cdbf802 100644

--- a/content/public/browser/web_contents_delegate.h

+++ b/content/public/browser/web_contents_delegate.h

@@ -98,7 +98,7 @@ class CONTENT_EXPORT WebContentsDelegate {

// Allows the delegate to optionally cancel navigations that attempt to

// transfer to a different process between the start of the network load and

// commit. Defaults to true.

- virtual bool ShouldTransferNavigation();

+ virtual bool ShouldTransferNavigation(bool is_main_frame_navigation);

// Called to inform the delegate that the WebContents's navigation state

// changed. The |changed_flags| indicates the parts of the navigation state