content/browser/web_contents/web_contents_impl.h - Issue 2352083003: Allow top-level navigation in extension pop-ups if it only triggers a download.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 2352083003: Allow top-level navigation in extension pop-ups if it only triggers a download. (Closed)

Patch Set: Changed bug reference (in a TODO comment) to a fresh bug. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 935dc7d1fba1d7b00ced85ffd26bc138bf7007a2..4087f1a026860fc65af3f00a1a1be05cf8c5fb61 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -604,7 +604,7 @@ class CONTENT_EXPORT WebContentsImpl

ReloadType reload_type) override;

void RequestOpenURL(RenderFrameHostImpl* render_frame_host,

const OpenURLParams& params) override;

- bool ShouldTransferNavigation() override;

+ bool ShouldTransferNavigation(bool is_main_frame_navigation) override;

bool ShouldPreserveAbortedURLs() override;

void DidStartLoading(FrameTreeNode* frame_tree_node,

bool to_different_document) override;