chrome/test/data/extensions/api_test/browser_action/popup_with_form/manifest.json - Issue 2352083003: Allow top-level navigation in extension pop-ups if it only triggers a download.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/browser_action/popup_with_form/manifest.json

Issue 2352083003: Allow top-level navigation in extension pop-ups if it only triggers a download. (Closed)

Patch Set: Changed bug reference (in a TODO comment) to a fresh bug. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.cc ('k') | chrome/test/data/extensions/api_test/browser_action/popup_with_form/other_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/browser_action/popup_with_form/manifest.json

diff --git a/chrome/test/data/extensions/api_test/browser_action/popup_with_iframe/manifest.json b/chrome/test/data/extensions/api_test/browser_action/popup_with_form/manifest.json

similarity index 51%

copy from chrome/test/data/extensions/api_test/browser_action/popup_with_iframe/manifest.json

copy to chrome/test/data/extensions/api_test/browser_action/popup_with_form/manifest.json

index b9890e90566a2f5f746489a3cf922d6db5ac06a1..ff856f8a4701630fa4797614a12610b5026ad444 100644

--- a/chrome/test/data/extensions/api_test/browser_action/popup_with_iframe/manifest.json

+++ b/chrome/test/data/extensions/api_test/browser_action/popup_with_form/manifest.json

@@ -1,8 +1,8 @@

{

- "name": "Popup with iframe",

+ "name": "Popup with form",

"version": "0.1",

"manifest_version": 2,

- "description": "Test a browser action popup with an iframe",

+ "description": "Test for navigating a browser action popup via POST",

"browser_action": {

"default_popup": "popup.html"

}