content/browser/frame_host/navigator_impl.cc - Issue 2352083003: Allow top-level navigation in extension pop-ups if it only triggers a download.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 2352083003: Allow top-level navigation in extension pop-ups if it only triggers a download. (Closed)

Patch Set: Going back to !defined(OS_CHROMEOS) as download shelf verification trigger. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index ca9ce6b7dafe92a1beda4848ff14b56078eeeb05..71c1143d4d94ce6e660c1ba866bbb99a78506f7b 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -759,7 +759,8 @@ void NavigatorImpl::RequestTransferURL(

SiteIsolationPolicy::AreCrossProcessFramesPossible());

// Allow the delegate to cancel the transfer.

- if (!delegate_->ShouldTransferNavigation())

+ if (!delegate_->ShouldTransferNavigation(

+ render_frame_host->frame_tree_node()->IsMainFrame()))

return;

GURL dest_url(url);