Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 2352083003: Allow top-level navigation in extension pop-ups if it only triggers a download. (Closed)
Patch Set: Addressed CR feedback from creis@. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_request.cc
diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc
index 63679331dcc375c897e23237f57d72e9cde4d39a..ba5c5a5c74aae75f748ab7ec8017c573402e3a25 100644
--- a/content/browser/frame_host/navigation_request.cc
+++ b/content/browser/frame_host/navigation_request.cc
@@ -359,9 +359,8 @@ void NavigationRequest::OnResponseStarted(
// renderer, allow the embedder to cancel the transfer.
if (!browser_initiated_ &&
render_frame_host != frame_tree_node_->current_frame_host() &&
- !frame_tree_node_->navigator()
- ->GetDelegate()
- ->ShouldTransferNavigation()) {
+ !frame_tree_node_->navigator()->GetDelegate()->ShouldTransferNavigation(
+ frame_tree_node_->IsMainFrame())) {
frame_tree_node_->ResetNavigationRequest(false);
return;
}

Powered by Google App Engine
This is Rietveld 408576698