Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3554)

Unified Diff: extensions/renderer/api/display_source/wifi_display/wifi_display_media_packetizer_unittest.cc

Issue 2352043002: [chrome.displaySource] Avoid unit test linkage errors. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api/display_source/wifi_display/wifi_display_media_packetizer_unittest.cc
diff --git a/extensions/renderer/api/display_source/wifi_display/wifi_display_media_packetizer_unittest.cc b/extensions/renderer/api/display_source/wifi_display/wifi_display_media_packetizer_unittest.cc
index eae5c270f914dec31a34b05eda9766c940046c3e..d243ca0fb22aee20931001afb3bdd0efbd0da4d1 100644
--- a/extensions/renderer/api/display_source/wifi_display/wifi_display_media_packetizer_unittest.cc
+++ b/extensions/renderer/api/display_source/wifi_display/wifi_display_media_packetizer_unittest.cc
@@ -168,9 +168,9 @@ class FakeTransportStreamPacketizer
std::vector<std::vector<uint8_t>> headers_;
};
-struct ProgramClockReference {
- static const uint64_t kInvalidBase = ~static_cast<uint64_t>(0u);
+const uint64_t kInvalidProgramClockReferenceBase = ~static_cast<uint64_t>(0u);
+struct ProgramClockReference {
uint64_t base;
uint16_t extension;
};
@@ -509,7 +509,7 @@ class WiFiDisplayElementaryStreamUnitPacketizationTest
// where
// parsed_pcr_value = 300 * parsed_pcr_.base + parsed_pcr_.extension
// but allow parsed_pcr_.base and parsed_dts to wrap around in 33 bits.
- EXPECT_NE(ProgramClockReference::kInvalidBase, parsed_pcr_.base);
+ EXPECT_NE(kInvalidProgramClockReferenceBase, parsed_pcr_.base);
EXPECT_LE(
300u * ((parsed_dts - parsed_pcr_.base) & ts::kTimeStampMask) -
parsed_pcr_.extension,
@@ -549,7 +549,7 @@ class WiFiDisplayElementaryStreamUnitPacketizationTest
size_t program_clock_reference;
size_t elementary_streams[3];
} continuity_ = {0u, 0u, 0u, {0u, 0u, 0u}};
- ProgramClockReference parsed_pcr_ = {ProgramClockReference::kInvalidBase, 0u};
+ ProgramClockReference parsed_pcr_ = {kInvalidProgramClockReferenceBase, 0u};
};
TEST_P(WiFiDisplayElementaryStreamUnitPacketizationTest,
@@ -781,7 +781,7 @@ TEST(WiFiDisplayTransportStreamPacketizationTest, EncodeToMediaDatagramPacket) {
auto packets = packetizer.FetchPackets();
// Check datagram packets.
- ProgramClockReference pcr = {ProgramClockReference::kInvalidBase, 0u};
+ ProgramClockReference pcr = {kInvalidProgramClockReferenceBase, 0u};
uint16_t sequence_number = 0u;
uint32_t synchronization_source_identifier;
auto transport_stream_packet_it = transport_stream_packets.cbegin();
@@ -810,7 +810,7 @@ TEST(WiFiDisplayTransportStreamPacketizationTest, EncodeToMediaDatagramPacket) {
// Packet time stamp.
uint32_t parsed_time_stamp;
EXPECT_TRUE(header_reader.ReadU32(&parsed_time_stamp));
- if (pcr.base == ProgramClockReference::kInvalidBase) {
+ if (pcr.base == kInvalidProgramClockReferenceBase) {
// This happens only for the first datagram packet.
EXPECT_TRUE(&packet == &packets.front());
// Ensure that the next datagram packet reaches the else branch.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698