Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2351963004: V8: Remove xcode-ninja bot (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, Nico
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

V8: Remove xcode-ninja bot Reduces maintenance as it is unlikely that we will break gn's xcode generator. BUG=645890 Committed: https://chromium.googlesource.com/chromium/tools/build/+/5c1d87a88517d25aef1d7a4349dc827167d72b1c

Patch Set 1 #

Patch Set 2 : Remove recipe side #

Patch Set 3 : Remove bot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -311 lines) Patch
M masters/master.client.v8/master.cfg View 1 2 3 chunks +0 lines, -10 lines 0 comments Download
M masters/master.client.v8/slaves.cfg View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/v8/builders.py View 1 1 chunk +0 lines, -10 lines 0 comments Download
M scripts/slave/recipe_modules/v8/chromium_config.py View 1 1 chunk +0 lines, -6 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64___xcode.json View 1 1 chunk +0 lines, -284 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Michael Achenbach
PTAL. This is one of two V8 bots not supporting MB, therefore this asynchronous switch ...
4 years, 3 months ago (2016-09-20 14:31:22 UTC) #3
Nico
Are you aware of instances where you broke gn --ide=xcode? If not, maybe delete the ...
4 years, 3 months ago (2016-09-20 14:33:28 UTC) #6
Michael Achenbach
On 2016/09/20 14:33:28, Nico wrote: > Are you aware of instances where you broke gn ...
4 years, 3 months ago (2016-09-20 14:38:51 UTC) #7
Dirk Pranke
On 2016/09/20 14:38:51, machenbach (slow) wrote: > On 2016/09/20 14:33:28, Nico wrote: > > Are ...
4 years, 3 months ago (2016-09-20 21:26:04 UTC) #8
Michael Achenbach
PTAL - removing the bot. The "M" at the expectation file is a bit odd. ...
4 years, 3 months ago (2016-09-21 12:52:46 UTC) #10
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-21 16:38:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351963004/40001
4 years, 2 months ago (2016-09-24 12:03:41 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-24 12:07:21 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/5c1d87a88517d25aef1d...

Powered by Google App Engine
This is Rietveld 408576698