Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Side by Side Diff: chrome/test/data/webui/settings/languages_page_browsertest.js

Issue 2351963003: MD Settings: Replace language detail page with dropdown menu items (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** @fileoverview Suite of tests for settings-languages-page. */ 5 /** @fileoverview Suite of tests for settings-languages-page. */
6 6
7 /** @const {string} Path to root from chrome/test/data/webui/settings/. */ 7 /** @const {string} Path to root from chrome/test/data/webui/settings/. */
8 var ROOT_PATH = '../../../../../'; 8 var ROOT_PATH = '../../../../../';
9 9
10 // Polymer BrowserTest fixture. 10 // Polymer BrowserTest fixture.
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 return domRepeat.itemForElement(el) && 228 return domRepeat.itemForElement(el) &&
229 domRepeat.itemForElement(el).language == newLanguage; 229 domRepeat.itemForElement(el).language == newLanguage;
230 }); 230 });
231 231
232 // Open the menu and select Remove. 232 // Open the menu and select Remove.
233 MockInteractions.tap(item.querySelector('paper-icon-button')); 233 MockInteractions.tap(item.querySelector('paper-icon-button'));
234 234
235 var languageMenu = assert(languagesPage.$$('cr-shared-menu')); 235 var languageMenu = assert(languagesPage.$$('cr-shared-menu'));
236 assertTrue(languageMenu.menuOpen); 236 assertTrue(languageMenu.menuOpen);
237 var removeMenuItem = assert(languageMenu.querySelector( 237 var removeMenuItem = assert(languageMenu.querySelector(
238 '.dropdown-item:last-of-type')); 238 '.dropdown-item:last-child'));
239 assertFalse(removeMenuItem.disabled); 239 assertFalse(removeMenuItem.disabled);
240 MockInteractions.tap(removeMenuItem); 240 MockInteractions.tap(removeMenuItem);
241 assertFalse(languageMenu.menuOpen); 241 assertFalse(languageMenu.menuOpen);
242 242
243 // We should go back down to the original number of enabled languages. 243 // We should go back down to the original number of enabled languages.
244 return whenNumEnabledLanguagesBecomes(numEnabled).then(function() { 244 return whenNumEnabledLanguagesBecomes(numEnabled).then(function() {
245 assertFalse(languageHelper.isLanguageEnabled(newLanguage.code)); 245 assertFalse(languageHelper.isLanguageEnabled(newLanguage.code));
246 }); 246 });
247 }); 247 });
248 }); 248 });
249 249
250 test('language detail', function() {
251 var languageOptionsDropdownTrigger = languagesCollapse.querySelector(
252 'paper-icon-button');
253 MockInteractions.tap(languageOptionsDropdownTrigger);
254 var languageDetailMenuItem = languagesPage.root.querySelectorAll(
255 'cr-shared-menu .dropdown-item')[2];
256 MockInteractions.tap(languageDetailMenuItem);
257
258 var languageDetailPage =
259 languagesPage.$$('settings-language-detail-page');
260 assertTrue(!!languageDetailPage);
261 assertEquals('en-US', languageDetailPage.detail.language.code);
262 });
263
264 test('manage input methods', function() { 250 test('manage input methods', function() {
265 var inputMethodsCollapse = languagesPage.$.inputMethodsCollapse; 251 var inputMethodsCollapse = languagesPage.$.inputMethodsCollapse;
266 var inputMethodSettingsExist = !!inputMethodsCollapse; 252 var inputMethodSettingsExist = !!inputMethodsCollapse;
267 if (cr.isChromeOS) { 253 if (cr.isChromeOS) {
268 assertTrue(inputMethodSettingsExist); 254 assertTrue(inputMethodSettingsExist);
269 var manageInputMethodsButton = 255 var manageInputMethodsButton =
270 inputMethodsCollapse.querySelector('.list-button:last-of-type'); 256 inputMethodsCollapse.querySelector('.list-button:last-of-type');
271 MockInteractions.tap(manageInputMethodsButton); 257 MockInteractions.tap(manageInputMethodsButton);
272 assertTrue(!!languagesPage.$$('settings-manage-input-methods-page')); 258 assertTrue(!!languagesPage.$$('settings-manage-input-methods-page'));
273 } else { 259 } else {
(...skipping 13 matching lines...) Expand all
287 assertTrue(!!languagesPage.$$('settings-edit-dictionary-page')); 273 assertTrue(!!languagesPage.$$('settings-edit-dictionary-page'));
288 } 274 }
289 }); 275 });
290 }.bind(this)); 276 }.bind(this));
291 277
292 // TODO(michaelpg): Test more aspects of the languages UI. 278 // TODO(michaelpg): Test more aspects of the languages UI.
293 279
294 // Run all registered tests. 280 // Run all registered tests.
295 mocha.run(); 281 mocha.run();
296 }); 282 });
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698