Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2351953002: Revert of Async/await Promise dependency graph (Closed)

Created:
4 years, 3 months ago by Dan Ehrenberg
Modified:
4 years, 3 months ago
Reviewers:
kozy, adamk, jgruber
CC:
caitp, gsathya, neis, v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Async/await Promise dependency graph (patchset #30 id:550001 of https://codereview.chromium.org/2317383002/ ) Reason for revert: Need to break up test into smaller tests to avoid timeouts Original issue's description: > Async/await Promise dependency graph > > This patch knits together Promises returned by async/await such that when > one async function awaits the result of another one, catch prediction works > across the boundaries, whether the exception comes synchronously or > asynchronously. Edges are added in three places: > - When a locally uncaught await happens, if the value passed into await > is a Promise, from the awaited value to the Promise under construction > in the broader async function > - From a "throwaway" Promise, which may be found on the Promise debug > stack, to the Promise under construction in the async function that > surrounds it > - When a Promise is resolved with another Promise (e.g., when returning a > Promise from an async function) > > BUG=v8:5167 > > Committed: https://crrev.com/7265fdde7c76b9f875b40b0b139515936d491d64 > Cr-Commit-Position: refs/heads/master@{#39522} TBR=adamk@chromium.org,jgruber@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5167 Committed: https://crrev.com/100336f5dc73193689baa9c2da5a0dc4eafdb64a Cr-Commit-Position: refs/heads/master@{#39523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -156 lines) Patch
M src/heap-symbols.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/js/harmony-async-await.js View 4 chunks +17 lines, -29 lines 0 comments Download
M src/js/prologue.js View 1 chunk +1 line, -2 lines 0 comments Download
M src/js/promise.js View 11 chunks +23 lines, -59 lines 0 comments Download
M src/parsing/parser.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/async-debug-caught-exception-cases.js View 4 chunks +3 lines, -60 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dan Ehrenberg
Created Revert of Async/await Promise dependency graph
4 years, 3 months ago (2016-09-20 01:09:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351953002/1
4 years, 3 months ago (2016-09-20 01:09:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 01:09:21 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 01:09:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/100336f5dc73193689baa9c2da5a0dc4eafdb64a
Cr-Commit-Position: refs/heads/master@{#39523}

Powered by Google App Engine
This is Rietveld 408576698