Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Issue 2351943005: Revert of Update V8 DEPS. (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Update V8 DEPS. (patchset #1 id:1 of https://codereview.chromium.org/2360463002/ ) Reason for revert: Breaks https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug%20builder/builds/3144 Original issue's description: > Update V8 DEPS. > > Rolling v8/base/trace_event/common to 199985e01e17b5a4888f83648b7cc119779e9245 > > Rolling v8/build to 4803815de7294778a1496c4e7f3e84ee48e243ef > > Rolling v8/buildtools to 57649e5e2001ba1f5e5d45f5a838c616ea0e9cb9 > > Rolling v8/tools/clang to cca919b21f2436ba1585f7e9de2702ba64fbd8bf > > TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org > > Committed: https://crrev.com/0ed1254d8103b40d5880601bf73b6c56e4d5716d > Cr-Commit-Position: refs/heads/master@{#39570} TBR=hablich@chromium.org,vogelheim@chromium.org,v8-autoroll@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a7455beba142fd5b3d52eb624cb8cc7b0e012e04 Cr-Commit-Position: refs/heads/master@{#39578}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M DEPS View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Update V8 DEPS.
4 years, 3 months ago (2016-09-21 08:06:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351943005/1
4 years, 3 months ago (2016-09-21 08:06:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 08:06:27 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 08:07:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7455beba142fd5b3d52eb624cb8cc7b0e012e04
Cr-Commit-Position: refs/heads/master@{#39578}

Powered by Google App Engine
This is Rietveld 408576698