Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2351943004: Switch NaCl SDK release builders from svn to git (Closed)

Created:
4 years, 3 months ago by Sam Clegg
Modified:
4 years, 3 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Switch NaCl SDK release builders from svn to git For the release builders we were pointing at the svn buildspec repo which no longer exists. BUG=648344 Committed: https://chromium.googlesource.com/chromium/tools/build/+/2ad289dbd9e6975d7348be8e84d30e24b924501f

Patch Set 1 #

Patch Set 2 : update expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_multirel.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multirel.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multirel.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Sam Clegg
Perhaps we can just drop this checkout? But this should fix it in the short ...
4 years, 3 months ago (2016-09-20 23:03:54 UTC) #2
bradn
lgtm
4 years, 3 months ago (2016-09-21 01:26:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351943004/20001
4 years, 3 months ago (2016-09-21 01:26:30 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 01:33:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/2ad289dbd9e6975d7348...

Powered by Google App Engine
This is Rietveld 408576698