Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 2351933002: Fix Observatory recompiles on fresh build (Closed)

Created:
4 years, 3 months ago by Cutch
Modified:
4 years, 3 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Observatory recompiles on fresh build - [x] GYPI: Remove buggy dependency on the sdk's packages.stamp which shouldn't have been a dependency in the first place. - [x] GN: Switch output names to match new non-polymer based build BUG= Committed: https://github.com/dart-lang/sdk/commit/d78cbce63d0e7854accedaf7d700790ca1f4fb00

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M runtime/observatory/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/observatory.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (4 generated)
Cutch
TBR
4 years, 3 months ago (2016-09-19 23:41:37 UTC) #4
Cutch
4 years, 3 months ago (2016-09-19 23:41:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d78cbce63d0e7854accedaf7d700790ca1f4fb00 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698