Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2351903004: [TTS] Rename ContextualSearchFieldTrial unit tests. (Closed)

Created:
4 years, 3 months ago by Donn Denman
Modified:
4 years, 3 months ago
Reviewers:
Theresa
CC:
chromium-reviews, twellington+watch_chromium.org, donnd+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Rename ContextualSearchFieldTrial unit tests. Updates unit tests for FieldTrial (which were misspelled FieldTrail). BUG= Committed: https://crrev.com/a130331129068c4210fd8675d2ccbc157042293a Cr-Commit-Position: refs/heads/master@{#419893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M chrome/browser/android/contextualsearch/contextual_search_field_trial_unittest.cc View 3 chunks +25 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Donn Denman
Theresa, PTAL. Thanks!
4 years, 3 months ago (2016-09-20 21:50:59 UTC) #2
Theresa
lgtm
4 years, 3 months ago (2016-09-20 22:24:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351903004/1
4 years, 3 months ago (2016-09-20 22:35:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 23:20:00 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 23:22:24 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a130331129068c4210fd8675d2ccbc157042293a
Cr-Commit-Position: refs/heads/master@{#419893}

Powered by Google App Engine
This is Rietveld 408576698