Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 23519010: cleanup cctest generally and remove ctest::context (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

cleanup cctest generally and remove ctest::context R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16831

Patch Set 1 #

Patch Set 2 : arm fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -78 lines) Patch
M test/cctest/cctest.h View 3 chunks +20 lines, -11 lines 0 comments Download
M test/cctest/cctest.cc View 3 chunks +22 lines, -31 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M test/cctest/test-assembler-x64.cc View 2 chunks +1 line, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 5 chunks +12 lines, -9 lines 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +1 line, -1 line 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 8 chunks +29 lines, -16 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-strings.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 3 months ago (2013-09-19 11:44:00 UTC) #1
Sven Panne
lgtm
7 years, 3 months ago (2013-09-19 12:09:00 UTC) #2
dcarney
7 years, 3 months ago (2013-09-19 13:31:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16831 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698