Issue 23519003: Mark anonymous indexed getters argument as mandatory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23519003: Mark anonymous indexed getters argument as mandatory (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
haraken

CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, do-not-use

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Mark anonymous indexed getters argument as mandatory Mark anonymous indexed getters argument as mandatory since there is no way for the caller to omit the index. The generated bindings are exactly the same and therefore there is no behavior change. R=haraken BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156998

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	Source/core/css/WebKitCSSFilterValue.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/WebKitCSSTransformValue.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLFormControlsCollection.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23519003/1

7 years, 3 months ago (2013-08-30 16:45:34 UTC) #3

Message was sent while issue was closed.

Change committed as 156998

Expand Messages | Collapse Messages