Remove __gCrWeb.invokeOnHostImmediate.

Remove __gCrWeb.invokeOnHostImmediate.

InvokeOnHost used to queue while the UIWebView URL was verified.
Since InvokeOnHost no longer queues with WKWebView, the logic in
InvokeOnHostImmediate is now the same and can be removed.

BUG=579697
Committed: https://crrev.com/ced9605aea022ef7b68ef9d2a241ccb269ff6c38
Cr-Commit-Position: refs/heads/master@{#420059}

[michaeldo, 2016-09-19 22:40:28]

michaeldo@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-09-19 23:20:40]

https://codereview.chromium.org/2351893003/diff/1/ios/web/web_state/js/resour...
File ios/web/web_state/js/resources/message.js (right):

https://codereview.chromium.org/2351893003/diff/1/ios/web/web_state/js/resour...
ios/web/web_state/js/resources/message.js:41: // If there is no document or
body, the command will be silently dropped.
Should we still enqueue the message, even if we are not calling |sendQueue_|.

https://codereview.chromium.org/2351893003/diff/1/ios/web/web_state/js/resour...
ios/web/web_state/js/resources/message.js:41: // If there is no document or
body, the command will be silently dropped.
Could you please clarify what do you mean by |will be silently dropped|. Will it
be dropped by webkit messaging system? Or by Chrome code.

[michaeldo, 2016-09-20 18:26:18]

https://codereview.chromium.org/2351893003/diff/1/ios/web/web_state/js/resour...
File ios/web/web_state/js/resources/message.js (right):

https://codereview.chromium.org/2351893003/diff/1/ios/web/web_state/js/resour...
ios/web/web_state/js/resources/message.js:41: // If there is no document or
body, the command will be silently dropped.
On 2016/09/19 23:20:40, Eugene But wrote:
> Could you please clarify what do you mean by |will be silently dropped|. Will
it
> be dropped by webkit messaging system? Or by Chrome code.

It is dropped here by the early return.

This logic was from invokeOnHostImmediate. I think it is better to move this to
setExternalRequest since that is the only code that was using the "immediate"
call. In that case, I don't think we need to enqueue the message. It looks like
it will only return early if a 'click' occurs before the document and body
exist.

(I can't go back far enough in history to get context about why this code was
added.)

[Eugene But (OOO till 7-30), 2016-09-20 22:05:13]

eugenebut@chromium.org changed reviewers:
+ jyquinn@chromium.org

[Eugene But (OOO till 7-30), 2016-09-20 22:05:14]

lgtm, Jackie, do you remember by any chance why we dropped immediate messages if
there was no document object?
https://codereview.chromium.org/2351893003/diff/1/ios/web/web_state/js/resour...

https://codereview.chromium.org/2351893003/diff/20001/ios/web/web_state/js/re...
File ios/web/web_state/js/resources/core.js (right):

https://codereview.chromium.org/2351893003/diff/20001/ios/web/web_state/js/re...
ios/web/web_state/js/resources/core.js:545: // If there is no document or body,
the request will be silently dropped
Do you even need this comment? It simply repeats the code and not helping with
anything.

[Jackie Quinn, 2016-09-21 00:04:44]

On 2016/09/20 22:05:14, Eugene But wrote:
> lgtm, Jackie, do you remember by any chance why we dropped immediate messages
if
> there was no document object?
>
https://codereview.chromium.org/2351893003/diff/1/ios/web/web_state/js/resour...
> 
>
https://codereview.chromium.org/2351893003/diff/20001/ios/web/web_state/js/re...
> File ios/web/web_state/js/resources/core.js (right):
> 
>
https://codereview.chromium.org/2351893003/diff/20001/ios/web/web_state/js/re...
> ios/web/web_state/js/resources/core.js:545: // If there is no document or
body,
> the request will be silently dropped
> Do you even need this comment? It simply repeats the code and not helping with
> anything.

In the UIWebView days, you couldn't send messages until document.body existed.
Messages in this category were dropped because there was no point in queuing
them (I don't remember the exact reasons for each of the message).

[Eugene But (OOO till 7-30), 2016-09-21 00:18:22]

On 2016/09/21 00:04:44, Jackie Quinn wrote:
> On 2016/09/20 22:05:14, Eugene But wrote:
> > lgtm, Jackie, do you remember by any chance why we dropped immediate
messages
> if
> > there was no document object?
> >
>
https://codereview.chromium.org/2351893003/diff/1/ios/web/web_state/js/resour...
> > 
> >
>
https://codereview.chromium.org/2351893003/diff/20001/ios/web/web_state/js/re...
> > File ios/web/web_state/js/resources/core.js (right):
> > 
> >
>
https://codereview.chromium.org/2351893003/diff/20001/ios/web/web_state/js/re...
> > ios/web/web_state/js/resources/core.js:545: // If there is no document or
> body,
> > the request will be silently dropped
> > Do you even need this comment? It simply repeats the code and not helping
with
> > anything.
> 
> In the UIWebView days, you couldn't send messages until document.body existed.
> Messages in this category were dropped because there was no point in queuing
> them (I don't remember the exact reasons for each of the message).
Thanks, Jackie. With UIWebView we were sending the messages using iframes, which
is not the case for WKWebVIew and we should drop |if (!document ||
!document.body)| early return.

[michaeldo, 2016-09-21 14:53:34]

The CQ bit was checked by michaeldo@chromium.org

[michaeldo, 2016-09-21 14:53:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2351893003/#ps40001
(title: "Remove early return.")

[commit-bot: I haz the power, 2016-09-21 14:53:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 15:03:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-21 15:06:19]

Description was changed from

==========
Remove __gCrWeb.invokeOnHostImmediate.

InvokeOnHost used to queue while the UIWebView URL was verified.
Since InvokeOnHost no longer queues with WKWebView, the logic in
InvokeOnHostImmediate is now the same and can be removed.

BUG=579697
==========

to

==========
Remove __gCrWeb.invokeOnHostImmediate.

InvokeOnHost used to queue while the UIWebView URL was verified.
Since InvokeOnHost no longer queues with WKWebView, the logic in
InvokeOnHostImmediate is now the same and can be removed.

BUG=579697

Committed: https://crrev.com/ced9605aea022ef7b68ef9d2a241ccb269ff6c38
Cr-Commit-Position: refs/heads/master@{#420059}
==========

[commit-bot: I haz the power, 2016-09-21 15:06:20]

Patchset 3 (id:??) landed as
https://crrev.com/ced9605aea022ef7b68ef9d2a241ccb269ff6c38
Cr-Commit-Position: refs/heads/master@{#420059}