ash/public/interfaces/system_tray.mojom - Issue 2351893002: mash: Fix system tray clock 12/24 hour time setting

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/public/interfaces/system_tray.mojom

Issue 2351893002: mash: Fix system tray clock 12/24 hour time setting (Closed)

Patch Set: tweak Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module ash.mojom;

	6

	7 // Allows clients (e.g. Chrome browser) to control the ash system tray menu.

	8 interface SystemTray {
	James Cook 2016/09/19 22:51:38 Do we have a naming convention for these things? m Do we have a naming convention for these things? msw was using ShelfController and WallpaperController. I suspect that was because just "Shelf" is generic and there are shelf-y controller classes in //chrome. But that feels odd to me, since mojom.ShelfController is implemented by ShelfDelegateMus, not some kind of ControllerImpl. Should I stick with this, or switch to SystemTrayController for consistency? James Cook 2016/09/20 01:52:11 Ping? Show quoted text On 2016/09/19 22:51:38, James Cook wrote: > Do we have a naming convention for these things? msw was using ShelfController > and WallpaperController. I suspect that was because just "Shelf" is generic and > there are shelf-y controller classes in //chrome. But that feels odd to me, > since mojom.ShelfController is implemented by ShelfDelegateMus, not some kind of > ControllerImpl. Should I stick with this, or switch to SystemTrayController for > consistency? Ping? sky 2016/09/20 02:45:16 Sorry, somehow missed your question. One naming co Show quoted text On 2016/09/20 01:52:11, James Cook wrote: > On 2016/09/19 22:51:38, James Cook wrote: > > Do we have a naming convention for these things? msw was using ShelfController > > and WallpaperController. I suspect that was because just "Shelf" is generic > and > > there are shelf-y controller classes in //chrome. But that feels odd to me, > > since mojom.ShelfController is implemented by ShelfDelegateMus, not some kind > of > > ControllerImpl. Should I stick with this, or switch to SystemTrayController > for > > consistency? > > Ping? Sorry, somehow missed your question. One naming convention we've gone with is Foo and FooClient. You can see that in WindowTree and WindowTreeClient. As you pointed out we aren't particularly consistent in ash code yet. I don't feel strongly here. I'm fine with SystemTray.
	9 // Sets the clock to use 24 hour time formatting if \|use_24_hour\| is true.

	10 // Otherwise sets 12 hour time formatting.

	11 SetUse24HourClock(bool use_24_hour);

	12 };

	13

	14 // TODO(jamescook): SystemTrayDelegate to communicate from ash to chrome.

OLD	NEW

« ash/mus/window_manager_application.cc ('K') | « ash/public/interfaces/BUILD.gn ('k') | chrome/app/mojo/chrome_manifest.json » ('j') | chrome/browser/ui/BUILD.gn » ('J')