Issue 2351863002: Generate SDK summaries using ASTs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2351863002: Generate SDK summaries using ASTs. (Closed)

Created:
4 years, 3 months ago by scheglov

Modified:
4 years, 3 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Generate SDK summaries using ASTs. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2fa34661d457293ee435a7e136414d888c68b119

Patch Set 1 #

Total comments: 1

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -19 lines)			Patch
M	pkg/analyzer/lib/src/summary/link.dart	View	2 chunks	+12 lines, -4 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/package_bundle_reader.dart	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	pkg/analyzer/lib/src/summary/summary_file_builder.dart	View	2 chunks	+70 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

lgtm https://codereview.chromium.org/2351863002/diff/1/pkg/analyzer/lib/src/summary/package_bundle_reader.dart File pkg/analyzer/lib/src/summary/package_bundle_reader.dart (right): https://codereview.chromium.org/2351863002/diff/1/pkg/analyzer/lib/src/summary/package_bundle_reader.dart#newcode204 pkg/analyzer/lib/src/summary/package_bundle_reader.dart:204: print('RRR $result for $target'); Looks like temporary debugging ...

4 years, 3 months ago (2016-09-19 19:17:04 UTC) #2

scheglov

4 years, 3 months ago (2016-09-19 19:20:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2fa34661d457293ee435a7e136414d888c68b119 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages