Only create ScopeInfos for scopes that really need one

Only create ScopeInfos for scopes that really need one

R=verwaest@chromium.org,marja@chromium.org

Committed: https://crrev.com/7d9a0375240495dc7bd5f56e1c6063fc3fdcb218
Cr-Commit-Position: refs/heads/master@{#39546}

[jochen (gone - plz use gerrit), 2016-09-20 08:58:31]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 08:58:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 09:25:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 09:26:00]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-09-20 09:27:51]

Description was changed from

==========
Only create ScopeInfos for scopes that really need one

... ignoring the debugger. Not for landing.

BUG=
==========

to

==========
Only create ScopeInfos for scopes that really need one

R=verwaest@chromium.org,marja@chromium.org
==========

[jochen (gone - plz use gerrit), 2016-09-20 09:27:52]

jochen@chromium.org changed reviewers:
+ marja@chromium.org, verwaest@chromium.org

[jochen (gone - plz use gerrit), 2016-09-20 09:28:19]

that version works... ptal

[jochen (gone - plz use gerrit), 2016-09-20 09:28:29]

ptal

[marja, 2016-09-20 09:48:25]

lgtm as in "looks good to me", not "I swear this is correct" :P

[Toon Verwaest, 2016-09-20 11:05:01]

https://codereview.chromium.org/2351823005/diff/20001/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2351823005/diff/20001/src/ast/scopes.cc#newco...
src/ast/scopes.cc:1051: // it has one, even if it doesn't need a scope info.
Add TODO(yangguo/jochen) to remove this requirement

[jochen (gone - plz use gerrit), 2016-09-20 11:12:55]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-09-20 11:12:55]

The patchset sent to the CQ was uploaded after l-g-t-m from marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2351823005/#ps40001
(title: "updates")

[commit-bot: I haz the power, 2016-09-20 11:13:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-09-20 11:13:18]

https://codereview.chromium.org/2351823005/diff/20001/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2351823005/diff/20001/src/ast/scopes.cc#newco...
src/ast/scopes.cc:1051: // it has one, even if it doesn't need a scope info.
On 2016/09/20 at 11:05:00, Toon Verwaest wrote:
> Add TODO(yangguo/jochen) to remove this requirement

done (also added to NeedsScopeInfo())

[Toon Verwaest, 2016-09-20 11:21:40]

Cool, lgtm

[commit-bot: I haz the power, 2016-09-20 11:46:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-20 11:47:30]

Description was changed from

==========
Only create ScopeInfos for scopes that really need one

R=verwaest@chromium.org,marja@chromium.org
==========

to

==========
Only create ScopeInfos for scopes that really need one

R=verwaest@chromium.org,marja@chromium.org

Committed: https://crrev.com/7d9a0375240495dc7bd5f56e1c6063fc3fdcb218
Cr-Commit-Position: refs/heads/master@{#39546}
==========

[commit-bot: I haz the power, 2016-09-20 11:47:31]

Patchset 3 (id:??) landed as
https://crrev.com/7d9a0375240495dc7bd5f56e1c6063fc3fdcb218
Cr-Commit-Position: refs/heads/master@{#39546}