Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7845)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_base.cc

Issue 2351823004: [Extensions] Consolidate ExtensionFunction::SendResponse()s (Closed)
Patch Set: ready Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager/private_api_base.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_base.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_base.cc
index 0e675c8efbf1faa72dca1fd53a4bf2f36d113f29..2dd89947572f8c374753cea10dc7a576184d9390 100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_base.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_base.cc
@@ -25,10 +25,12 @@ LoggedAsyncExtensionFunction::LoggedAsyncExtensionFunction()
LoggedAsyncExtensionFunction::~LoggedAsyncExtensionFunction() {
}
-void LoggedAsyncExtensionFunction::SendResponse(bool success) {
+void LoggedAsyncExtensionFunction::OnResponded() {
drive::EventLogger* logger = file_manager::util::GetLogger(GetProfile());
if (logger) {
int64_t elapsed = (base::Time::Now() - start_time_).InMilliseconds();
+ DCHECK(response_type());
+ bool success = *response_type() == SUCCEEDED;
if (log_on_completion_) {
logger->Log(logging::LOG_INFO, "%s[%d] %s. (elapsed time: %sms)", name(),
request_id(), success ? "succeeded" : "failed",
@@ -39,7 +41,7 @@ void LoggedAsyncExtensionFunction::SendResponse(bool success) {
name(), request_id(), base::Int64ToString(elapsed).c_str());
}
}
- ChromeAsyncExtensionFunction::SendResponse(success);
+ ChromeAsyncExtensionFunction::OnResponded();
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698