Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2351823003: [DevTools] Remove a bunch of styles from inspectorStyle.css. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove a bunch of styles from inspectorStyle.css. BUG=none Committed: https://crrev.com/fc93782cffcae4f541ed52f14e414847f55607af Cr-Commit-Position: refs/heads/master@{#419852}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 13 (5 generated)
dgozman
Take a look please.
4 years, 3 months ago (2016-09-20 00:18:24 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/2351823003/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js (left): https://codereview.chromium.org/2351823003/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js#oldcode741 third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:741: var element = rootElement.createChild("span", "error-message"); why remove the ...
4 years, 3 months ago (2016-09-20 17:58:28 UTC) #3
dgozman
https://codereview.chromium.org/2351823003/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js (left): https://codereview.chromium.org/2351823003/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js#oldcode741 third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:741: var element = rootElement.createChild("span", "error-message"); On 2016/09/20 17:58:28, lushnikov ...
4 years, 3 months ago (2016-09-20 18:11:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351823003/1
4 years, 3 months ago (2016-09-20 18:11:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/299593)
4 years, 3 months ago (2016-09-20 20:17:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351823003/1
4 years, 3 months ago (2016-09-20 20:26:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 21:07:41 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 21:09:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc93782cffcae4f541ed52f14e414847f55607af
Cr-Commit-Position: refs/heads/master@{#419852}

Powered by Google App Engine
This is Rietveld 408576698