Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/MetricsTestUtil.java

Issue 2351793003: Implement timing metrics for UrlRequest (Closed)
Patch Set: New test, and some rearranging things Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/MetricsTestUtil.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/MetricsTestUtil.java b/components/cronet/android/test/javatests/src/org/chromium/net/MetricsTestUtil.java
index 5823ef1a8d6fd0c2adc50e5ec694b8b0b7595d42..a6e8c7a25a2beed9650aee16f88cc7fc8ea0f56f 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/MetricsTestUtil.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/MetricsTestUtil.java
@@ -6,7 +6,9 @@ package org.chromium.net;
import static junit.framework.Assert.assertNotNull;
import static junit.framework.Assert.assertNull;
+import static junit.framework.Assert.assertTrue;
+import java.util.Date;
import java.util.LinkedList;
import java.util.NoSuchElementException;
import java.util.concurrent.Executor;
@@ -58,5 +60,69 @@ public class MetricsTestUtil {
assertNotNull(requestInfo);
mRequestInfo = requestInfo;
}
+
+ public void reset() {
+ mRequestInfo = null;
+ }
+ }
+
+ /**
+ * Check existence of all the timing metrics that apply to most test requests,
+ * except those that come from net::LoadTimingInfo::ConnectTiming.
+ * Also check some timing differences, focusing on things we can't check with asserts in the
+ * CronetMetrics constructor.
+ * Don't check push times here.
+ */
+ public static void checkTimingMetrics(
+ RequestFinishedInfo.Metrics metrics, Date startTime, Date endTime) {
+ assertNotNull(metrics.getRequestStart());
+ assertTrue(metrics.getRequestStart().after(startTime));
+ assertNotNull(metrics.getSendingStart());
+ assertTrue(metrics.getSendingStart().after(startTime));
+ assertNotNull(metrics.getSendingEnd());
+ assertTrue(metrics.getSendingEnd().before(endTime));
+ assertNotNull(metrics.getResponseStart());
+ assertTrue(metrics.getResponseStart().after(startTime));
+ assertNotNull(metrics.getResponseEnd());
+ assertTrue(metrics.getResponseEnd().before(endTime));
+ // Entire request should take more than 0 ms
+ assertTrue(metrics.getResponseEnd().getTime() - metrics.getRequestStart().getTime() > 0);
+ }
+
+ /**
+ * Check that the timing metrics which come from net::LoadTimingInfo::ConnectTiming exist,
+ * except SSL times in the case of non-https requests.
+ */
+ public static void checkHasConnectTiming(
+ RequestFinishedInfo.Metrics metrics, Date startTime, Date endTime, boolean isSsl) {
+ assertNotNull(metrics.getDnsStart());
+ assertTrue(metrics.getDnsStart().after(startTime));
+ assertNotNull(metrics.getDnsEnd());
+ assertTrue(metrics.getDnsEnd().before(endTime));
+ assertNotNull(metrics.getConnectStart());
+ assertTrue(metrics.getConnectStart().after(startTime));
+ assertNotNull(metrics.getConnectEnd());
+ assertTrue(metrics.getConnectEnd().before(endTime));
+ if (isSsl) {
+ assertNotNull(metrics.getSslStart());
+ assertTrue(metrics.getSslStart().after(startTime));
+ assertNotNull(metrics.getSslEnd());
+ assertTrue(metrics.getSslEnd().before(endTime));
+ } else {
+ assertNull(metrics.getSslStart());
+ assertNull(metrics.getSslEnd());
+ }
+ }
+
+ /**
+ * Check that the timing metrics from net::LoadTimingInfo::ConnectTiming don't exist.
+ */
+ public static void checkNoConnectTiming(RequestFinishedInfo.Metrics metrics) {
+ assertNull(metrics.getDnsStart());
+ assertNull(metrics.getDnsEnd());
+ assertNull(metrics.getSslStart());
+ assertNull(metrics.getSslEnd());
+ assertNull(metrics.getConnectStart());
+ assertNull(metrics.getConnectEnd());
}
}

Powered by Google App Engine
This is Rietveld 408576698