components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java - Issue 2351793003: Implement timing metrics for UrlRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

Issue 2351793003: Implement timing metrics for UrlRequest (Closed)

Patch Set: add more testing, and other comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java ('K') | « components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java » ('j') | components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

index 99860545f1d7d5d72fafccc1479b620b34a2960d..77b27c93f3fdcc723326a5c23b7335532101f511 100644

--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

@@ -427,6 +427,12 @@ public class CronetUrlRequestContext extends CronetEngine {

}

+ boolean hasRequestFinishedListener() {

+ synchronized (mFinishedListenerLock) {

+ return !mFinishedListenerList.isEmpty();

+ }

@Override

public URLConnection openConnection(URL url) {

return openConnection(url, Proxy.NO_PROXY);