Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

Issue 2351793003: Implement timing metrics for UrlRequest (Closed)
Patch Set: Small cleanups Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
index 7639ca72425ed835a7cf0c400eb09d305f2bbc63..a9e1f5b076f2ecfc6f2db8f5918863c640ad7aa6 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
@@ -6,17 +6,21 @@ package org.chromium.net;
import android.os.ConditionVariable;
import android.test.suitebuilder.annotation.LargeTest;
+import android.test.suitebuilder.annotation.SmallTest;
+
+import org.json.JSONObject;
import org.chromium.base.Log;
import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.base.test.util.Feature;
import org.chromium.net.CronetTestBase.OnlyRunNativeCronet;
-import org.json.JSONObject;
+import org.chromium.net.MetricsTestUtil.TestRequestFinishedListener;
import java.io.File;
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.IOException;
+import java.util.Date;
import java.util.concurrent.Executors;
/**
@@ -201,4 +205,59 @@ public class QuicTest extends CronetTestBase {
mTestFramework.mCronetEngine.shutdown();
}
+
+ @SmallTest
+ @OnlyRunNativeCronet
+ @Feature({"Cronet"})
+ public void testMetricsWithQuic() throws Exception {
+ mTestFramework = startCronetTestFrameworkWithUrlAndCronetEngineBuilder(null, mBuilder);
+ TestRequestFinishedListener requestFinishedListener = new TestRequestFinishedListener();
+ mTestFramework.mCronetEngine.addRequestFinishedListener(requestFinishedListener);
+
+ String quicURL = QuicTestServer.getServerURL() + "/simple.txt";
+ TestUrlRequestCallback callback = new TestUrlRequestCallback();
+
+ UrlRequest.Builder requestBuilder = new UrlRequest.Builder(
+ quicURL, callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+ Date startTime = new Date();
+ requestBuilder.build().start();
+ callback.blockForDone();
+ requestFinishedListener.blockUntilDone();
+ Date endTime = new Date();
+
+ assertEquals(200, callback.mResponseInfo.getHttpStatusCode());
+ assertEquals("quic/1+spdy/3", callback.mResponseInfo.getNegotiatedProtocol());
+
+ RequestFinishedInfo requestInfo = requestFinishedListener.getRequestInfo();
+ assertNotNull(requestInfo);
+ RequestFinishedInfo.Metrics metrics = requestInfo.getMetrics();
+ assertNotNull(metrics);
+
+ MetricsTestUtil.checkTimingMetrics(metrics, startTime, endTime);
+ MetricsTestUtil.checkHasConnectTiming(metrics, startTime, endTime, true);
+
+ // Second request should use the same connection and not have ConnectTiming numbers
+ callback = new TestUrlRequestCallback();
+ requestFinishedListener.reset();
+ requestBuilder = new UrlRequest.Builder(
+ quicURL, callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+ startTime = new Date();
+ requestBuilder.build().start();
+ callback.blockForDone();
+ requestFinishedListener.blockUntilDone();
+ endTime = new Date();
+
+ assertEquals(200, callback.mResponseInfo.getHttpStatusCode());
+ assertEquals("quic/1+spdy/3", callback.mResponseInfo.getNegotiatedProtocol());
+
+ requestInfo = requestFinishedListener.getRequestInfo();
+ assertNotNull(requestInfo);
+ metrics = requestInfo.getMetrics();
+ assertNotNull(metrics);
+
+ MetricsTestUtil.checkTimingMetrics(metrics, startTime, endTime);
+ MetricsTestUtil.checkNoConnectTiming(metrics);
+
+ mTestFramework.mCronetEngine.shutdown();
+ }
}

Powered by Google App Engine
This is Rietveld 408576698