components/cronet/android/java/src/org/chromium/net/impl/CronetMetrics.java - Issue 2351793003: Implement timing metrics for UrlRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetMetrics.java

Issue 2351793003: Implement timing metrics for UrlRequest (Closed)

Patch Set: Small cleanups Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/cronet_url_request_adapter.cc ('k') | components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/impl/CronetMetrics.java

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetMetrics.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetMetrics.java

index d4339e0da9c6c9c28b574825212f14e74a9e7a73..76fdd13a2611677b2ca9c63e9b49e04043ad9fe5 100644

--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetMetrics.java

+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetMetrics.java

@@ -99,7 +99,8 @@ public final class CronetMetrics extends RequestFinishedInfo.Metrics {

assert checkOrder(sslStartMs, sslEndMs);

assert checkOrder(sendingStartMs, sendingEndMs);

assert checkOrder(pushStartMs, pushEndMs);

- assert checkOrder(responseStartMs, responseEndMs);

+ // responseEnd always exists, so just check that it's after start

+ assert responseEndMs >= responseStartMs;

// Spot-check some of the other orderings

assert dnsStartMs >= requestStartMs || dnsStartMs == -1;

assert sendingStartMs >= requestStartMs || sendingStartMs == -1;