Implement timing metrics for UrlRequest

components/cronet/android/cronet_url_request_adapter.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_ADAPTER_H_
 #define COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_ADAPTER_H_
 
 #include <jni.h>
 
 #include <memory>
 #include <string>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/callback.h"
 #include "base/location.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
+#include "base/time/time.h"
 #include "net/base/request_priority.h"
 #include "net/url_request/url_request.h"
 #include "url/gurl.h"
 
 namespace base {
 class SingleThreadTaskRunner;
 }  // namespace base
 
 namespace net {
 class HttpRequestHeaders;
@@ skipping 22 matching lines @@
   // use cache, |jdisable_cache| has no effect. |jdisable_connection_migration|
   // causes connection migration to be disabled for this request if true. If
   // global connection migration flag is not enabled,
   // |jdisable_connection_migration| has no effect.
   CronetURLRequestAdapter(CronetURLRequestContextAdapter* context,
                           JNIEnv* env,
                           jobject jurl_request,
                           const GURL& url,
                           net::RequestPriority priority,
                           jboolean jdisable_cache,
-                          jboolean jdisable_connection_migration);
+                          jboolean jdisable_connection_migration,
+                          jboolean jenable_metrics);
   ~CronetURLRequestAdapter() override;
 
   // Methods called prior to Start are never called on network thread.
 
   // Sets the request method GET, POST etc.
   jboolean SetHttpMethod(JNIEnv* env,
                          const base::android::JavaParamRef<jobject>& jcaller,
                          const base::android::JavaParamRef<jstring>& jmethod);
 
   // Adds a header to the request before it starts.
@@ skipping 58 matching lines @@
       JNIEnv* env);
   void FollowDeferredRedirectOnNetworkThread();
   void ReadDataOnNetworkThread(
       scoped_refptr<IOBufferWithByteBuffer> read_buffer,
       int buffer_size);
   void DestroyOnNetworkThread(bool send_on_canceled);
 
   // Checks status of the request_adapter, return false if |is_success()| is
   // true, otherwise report error and cancel request_adapter.
   bool MaybeReportError(net::URLRequest* request) const;
+  // Reports metrics collected to the Java layer
+  void MaybeReportMetrics(net::URLRequest* request) const;
+  int64_t ConvertTime(base::TimeTicks ticks,

[xunjieli, 2016/09/20 21:53:33]

nit: add a documentation for this method. 
optional nit: maybe switch the place of last two arguments, so it's easier to
visually differentiate base::Time and base::TimeTicks.

[mgersh, 2016/09/30 23:47:14]

Done.

+                      base::Time start_time,
+                      base::TimeTicks start_ticks) const;
 
   CronetURLRequestContextAdapter* context_;
 
   // Java object that owns this CronetURLRequestContextAdapter.
   base::android::ScopedJavaGlobalRef<jobject> owner_;
 
   const GURL initial_url_;
   const net::RequestPriority initial_priority_;
   std::string initial_method_;
   int load_flags_;
   net::HttpRequestHeaders initial_request_headers_;
   std::unique_ptr<net::UploadDataStream> upload_;
 
   scoped_refptr<IOBufferWithByteBuffer> read_buffer_;
   std::unique_ptr<net::URLRequest> url_request_;
 
+  // Whether detailed metrics should be collected and reported to Java for this
+  // request.
+  bool enable_metrics_;

[xunjieli, 2016/09/22 18:28:59]

const bool.

[mgersh, 2016/09/30 23:47:14]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(CronetURLRequestAdapter);
 };
 
 }  // namespace cronet
 
 #endif  // COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_ADAPTER_H_