Implement timing metrics for UrlRequest

components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import android.os.ConditionVariable;
 import android.test.suitebuilder.annotation.LargeTest;
 import android.test.suitebuilder.annotation.SmallTest;
 
 import org.chromium.base.Log;
 import org.chromium.base.annotations.SuppressFBWarnings;
 import org.chromium.base.test.util.Feature;
 import org.chromium.net.CronetTestBase.OnlyRunNativeCronet;
 import org.json.JSONObject;
 
 import java.io.File;
 import java.io.FileInputStream;
 import java.io.FileNotFoundException;
 import java.io.IOException;
+import java.util.Date;
 import java.util.HashMap;
 import java.util.concurrent.Executors;
 
 /**
  * Tests making requests using QUIC.
  */
 public class QuicTest extends CronetTestBase {
     private static final String TAG = "cr.QuicTest";
     private CronetTestFramework mTestFramework;
     private CronetEngine.Builder mBuilder;
@@ skipping 193 matching lines @@
         // NETWORK_QUALITY_OBSERVATION_SOURCE_QUIC
         assertTrue(rttListener.rttObservationCount(2) > 0);
 
         // Verify that effective connection type callback is received and
         // effective connection type is correctly set.
         assertTrue(mTestFramework.mCronetEngine.getEffectiveConnectionType()
                 != EffectiveConnectionType.TYPE_UNKNOWN);
 
         mTestFramework.mCronetEngine.shutdown();
     }
+
+    @SmallTest
+    @OnlyRunNativeCronet
+    @Feature({"Cronet"})
+    public void testMetricsWithQuic() throws Exception {
+        mTestFramework = startCronetTestFrameworkWithUrlAndCronetEngineBuilder(null, mBuilder);
+        RequestFinishedInfoTest.TestExecutor testExecutor =
+                new RequestFinishedInfoTest.TestExecutor();
+        RequestFinishedInfoTest.TestRequestFinishedListener requestFinishedListener =
+                new RequestFinishedInfoTest.TestRequestFinishedListener(testExecutor);
+        mTestFramework.mCronetEngine.addRequestFinishedListener(requestFinishedListener);
+
+        String quicURL = QuicTestServer.getServerURL() + "/simple.txt";
+        TestUrlRequestCallback callback = new TestUrlRequestCallback();
+
+        UrlRequest.Builder requestBuilder = new UrlRequest.Builder(
+                quicURL, callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+        Date startTime = new Date();
+        requestBuilder.build().start();
+        callback.blockForDone();
+        Date endTime = new Date();
+        testExecutor.runAllTasks();
+
+        assertEquals(200, callback.mResponseInfo.getHttpStatusCode());
+        assertEquals("quic/1+spdy/3", callback.mResponseInfo.getNegotiatedProtocol());
+
+        RequestFinishedInfo requestInfo = requestFinishedListener.mRequestInfo;
+        assertNotNull(requestInfo);
+        RequestFinishedInfo.Metrics metrics = requestInfo.getMetrics();
+        assertNotNull(metrics);
+
+        RequestFinishedInfoTest.checkTimingMetrics(requestInfo.getMetrics(), startTime, endTime);
+        assertNotNull(metrics.getSslStart());
+        assertTrue(metrics.getSslStart().after(startTime));
+        assertNotNull(metrics.getSslEnd());
+        assertTrue(metrics.getSslEnd().before(endTime));

[xunjieli, 2016/09/20 14:32:46]

Suggest having util functions equivalent to "ExpectConnectTimingHasNoTimes" and
"ExpectConnectTimingHasTimes" in load_timing_info_test_util.cc.

Suggest adding a test where we make two requests, and check that the second
request has no connect timing.

[mgersh, 2016/09/20 20:48:25]

Done.

+
+        mTestFramework.mCronetEngine.shutdown();
+    }
 }