Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 2351643006: Remove unused string from ast-value-factory. (Closed)

Created:
4 years, 3 months ago by neis
Modified:
4 years, 3 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused string from ast-value-factory. R=adamk@chromium.org BUG= Committed: https://crrev.com/445e766fb834f2ed577feb8c4cfeca02f3185851 Cr-Commit-Position: refs/heads/master@{#39559}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/ast/ast-value-factory.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
4 years, 3 months ago (2016-09-20 16:49:53 UTC) #1
adamk
lgtm
4 years, 3 months ago (2016-09-20 17:12:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351643006/1
4 years, 3 months ago (2016-09-20 17:17:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 17:47:18 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 17:47:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/445e766fb834f2ed577feb8c4cfeca02f3185851
Cr-Commit-Position: refs/heads/master@{#39559}

Powered by Google App Engine
This is Rietveld 408576698