Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ic/mips/ic-mips.cc

Issue 2351643005: [ic] Reorder parameters of StoreIC_Miss and KeyedStoreIC_Miss runtime functions. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/ic.cc ('k') | src/ic/mips64/ic-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 692 matching lines...) Expand 10 before | Expand all | Expand 10 after
703 &fast_double_grow, &slow, kDontCheckMap, 703 &fast_double_grow, &slow, kDontCheckMap,
704 kIncrementLength, value, key, receiver, 704 kIncrementLength, value, key, receiver,
705 receiver_map, elements_map, elements); 705 receiver_map, elements_map, elements);
706 706
707 __ bind(&miss); 707 __ bind(&miss);
708 GenerateMiss(masm); 708 GenerateMiss(masm);
709 } 709 }
710 710
711 711
712 static void StoreIC_PushArgs(MacroAssembler* masm) { 712 static void StoreIC_PushArgs(MacroAssembler* masm) {
713 __ Push(StoreDescriptor::ReceiverRegister(), StoreDescriptor::NameRegister(), 713 __ Push(StoreWithVectorDescriptor::ValueRegister(),
714 StoreDescriptor::ValueRegister(),
715 StoreWithVectorDescriptor::SlotRegister(), 714 StoreWithVectorDescriptor::SlotRegister(),
716 StoreWithVectorDescriptor::VectorRegister()); 715 StoreWithVectorDescriptor::VectorRegister(),
716 StoreWithVectorDescriptor::ReceiverRegister(),
717 StoreWithVectorDescriptor::NameRegister());
717 } 718 }
718 719
719 720
720 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) { 721 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) {
721 StoreIC_PushArgs(masm); 722 StoreIC_PushArgs(masm);
722 723
723 __ TailCallRuntime(Runtime::kKeyedStoreIC_Miss); 724 __ TailCallRuntime(Runtime::kKeyedStoreIC_Miss);
724 } 725 }
725 726
726 void KeyedStoreIC::GenerateSlow(MacroAssembler* masm) { 727 void KeyedStoreIC::GenerateSlow(MacroAssembler* masm) {
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
887 break; 888 break;
888 default: 889 default:
889 UNIMPLEMENTED(); 890 UNIMPLEMENTED();
890 } 891 }
891 patcher.ChangeBranchCondition(branch_instr, opcode); 892 patcher.ChangeBranchCondition(branch_instr, opcode);
892 } 893 }
893 } // namespace internal 894 } // namespace internal
894 } // namespace v8 895 } // namespace v8
895 896
896 #endif // V8_TARGET_ARCH_MIPS 897 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ic/ic.cc ('k') | src/ic/mips64/ic-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698