Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: src/builtins/builtins-handler.cc

Issue 2351643005: [ic] Reorder parameters of StoreIC_Miss and KeyedStoreIC_Miss runtime functions. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/code-stubs.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/builtins/builtins.h" 5 #include "src/builtins/builtins.h"
6 #include "src/builtins/builtins-utils.h" 6 #include "src/builtins/builtins-utils.h"
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 typedef compiler::Node Node; 113 typedef compiler::Node Node;
114 typedef StoreWithVectorDescriptor Descriptor; 114 typedef StoreWithVectorDescriptor Descriptor;
115 115
116 Node* receiver = assembler->Parameter(Descriptor::kReceiver); 116 Node* receiver = assembler->Parameter(Descriptor::kReceiver);
117 Node* name = assembler->Parameter(Descriptor::kName); 117 Node* name = assembler->Parameter(Descriptor::kName);
118 Node* value = assembler->Parameter(Descriptor::kValue); 118 Node* value = assembler->Parameter(Descriptor::kValue);
119 Node* slot = assembler->Parameter(Descriptor::kSlot); 119 Node* slot = assembler->Parameter(Descriptor::kSlot);
120 Node* vector = assembler->Parameter(Descriptor::kVector); 120 Node* vector = assembler->Parameter(Descriptor::kVector);
121 Node* context = assembler->Parameter(Descriptor::kContext); 121 Node* context = assembler->Parameter(Descriptor::kContext);
122 122
123 assembler->TailCallRuntime(Runtime::kStoreIC_Miss, context, receiver, name, 123 assembler->TailCallRuntime(Runtime::kStoreIC_Miss, context, value, slot,
124 value, slot, vector); 124 vector, receiver, name);
125 } 125 }
126 126
127 void Builtins::Generate_StoreIC_Normal(MacroAssembler* masm) { 127 void Builtins::Generate_StoreIC_Normal(MacroAssembler* masm) {
128 StoreIC::GenerateNormal(masm); 128 StoreIC::GenerateNormal(masm);
129 } 129 }
130 130
131 void Builtins::Generate_StoreIC_Setter_ForDeopt(MacroAssembler* masm) { 131 void Builtins::Generate_StoreIC_Setter_ForDeopt(MacroAssembler* masm) {
132 NamedStoreHandlerCompiler::GenerateStoreViaSetterForDeopt(masm); 132 NamedStoreHandlerCompiler::GenerateStoreViaSetterForDeopt(masm);
133 } 133 }
134 134
(...skipping 19 matching lines...) Expand all
154 void Builtins::Generate_StoreIC_SlowSloppy(CodeStubAssembler* assembler) { 154 void Builtins::Generate_StoreIC_SlowSloppy(CodeStubAssembler* assembler) {
155 Generate_StoreIC_Slow(assembler, SLOPPY); 155 Generate_StoreIC_Slow(assembler, SLOPPY);
156 } 156 }
157 157
158 void Builtins::Generate_StoreIC_SlowStrict(CodeStubAssembler* assembler) { 158 void Builtins::Generate_StoreIC_SlowStrict(CodeStubAssembler* assembler) {
159 Generate_StoreIC_Slow(assembler, STRICT); 159 Generate_StoreIC_Slow(assembler, STRICT);
160 } 160 }
161 161
162 } // namespace internal 162 } // namespace internal
163 } // namespace v8 163 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698