Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: src/js/i18n.js

Issue 2351643002: [builtins] Move StringIndexOf to a builtin. (Closed)
Patch Set: Fix signed vs unsigned comparison Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-string.cc ('k') | src/js/string.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/i18n.js
diff --git a/src/js/i18n.js b/src/js/i18n.js
index 2e865906f2031c40dc4926eb3d6bced548a808cc..5dcf4db1ec46947233fe3f7ee5f6723a4421111a 100644
--- a/src/js/i18n.js
+++ b/src/js/i18n.js
@@ -34,7 +34,6 @@ var OverrideFunction = utils.OverrideFunction;
var patternSymbol = utils.ImportNow("intl_pattern_symbol");
var resolvedSymbol = utils.ImportNow("intl_resolved_symbol");
var SetFunctionName = utils.SetFunctionName;
-var StringIndexOf;
var StringSubstr;
var StringSubstring;
@@ -43,7 +42,6 @@ utils.Import(function(from) {
ArrayPush = from.ArrayPush;
InternalRegExpMatch = from.InternalRegExpMatch;
InternalRegExpReplace = from.InternalRegExpReplace;
- StringIndexOf = from.StringIndexOf;
StringSubstr = from.StringSubstr;
StringSubstring = from.StringSubstring;
});
@@ -834,7 +832,7 @@ function isStructuallyValidLanguageTag(locale) {
}
// Just return if it's a x- form. It's all private.
- if (%_Call(StringIndexOf, locale, 'x-') === 0) {
+ if (%StringIndexOf(locale, 'x-', 0) === 0) {
return true;
}
@@ -2099,7 +2097,7 @@ function LocaleConvertCase(s, locales, isToUpper) {
}
// StringSplit is slower than this.
- var pos = %_Call(StringIndexOf, language, '-');
+ var pos = %StringIndexOf(language, '-', 0);
if (pos != -1) {
language = %_Call(StringSubstring, language, 0, pos);
}
« no previous file with comments | « src/builtins/builtins-string.cc ('k') | src/js/string.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698