Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2351643002: [builtins] Move StringIndexOf to a builtin. (Closed)

Created:
4 years, 3 months ago by petermarshall
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer, Franzi
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Move StringIndexOf to a builtin. BUG=v8:5364

Patch Set 1 #

Patch Set 2 : Fix signed vs unsigned comparison #

Patch Set 3 : Merge in master to fix conflicts #

Patch Set 4 : Correct the text in the exception message #

Patch Set 5 : Fix signed vs unsigned comparison #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -58 lines) Patch
M src/bootstrapper.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/builtins.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M src/builtins/builtins-string.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M src/js/i18n.js View 1 2 3 4 4 chunks +2 lines, -4 lines 0 comments Download
M src/js/string.js View 1 2 3 chunks +0 lines, -17 lines 0 comments Download
M src/messages.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/objects.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.cc View 1 2 3 4 2 chunks +41 lines, -18 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 2 2 chunks +12 lines, -16 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (22 generated)
petermarshall
4 years, 3 months ago (2016-09-19 11:43:05 UTC) #15

          

Powered by Google App Engine
This is Rietveld 408576698