Issue 2351643002: [builtins] Move StringIndexOf to a builtin.

Issue 2351643002: [builtins] Move StringIndexOf to a builtin. (Closed)

Created:
4 years, 3 months ago by petermarshall

Modified:
4 years, 3 months ago

Reviewers:
Benedikt Meurer, Franzi

CC:
v8-reviews_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Description

[builtins] Move StringIndexOf to a builtin. BUG=v8:5364

Patch Set 2 : Fix signed vs unsigned comparison #

Patch Set 3 : Merge in master to fix conflicts #

Patch Set 4 : Correct the text in the exception message #

Patch Set 5 : Fix signed vs unsigned comparison #

Created: 4 years, 3 months ago

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -58 lines)
M	src/bootstrapper.cc	View	1 chunk	+2 lines, -0 lines	0 comments
M	src/builtins/builtins.h	View	1 chunk	+3 lines, -0 lines	0 comments
M	src/builtins/builtins-string.cc	View	1 chunk	+9 lines, -0 lines	0 comments
M	src/js/i18n.js	View	4 chunks	+2 lines, -4 lines	0 comments
M	src/js/string.js	View	3 chunks	+0 lines, -17 lines	0 comments
M	src/messages.cc	View	1 chunk	+5 lines, -1 line	0 comments
M	src/objects.h	View	1 chunk	+2 lines, -2 lines	0 comments
M	src/objects.cc	View	2 chunks	+41 lines, -18 lines	0 comments
M	src/runtime/runtime-strings.cc	View	2 chunks	+12 lines, -16 lines	0 comments

Depends on Patchset:

Issue 2339123002 Patch 120001

Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/9028)

4 years, 3 months ago (2016-09-19 09:56:51 UTC) #5

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

petermarshall

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

4 years, 3 months ago (2016-09-19 10:52:54 UTC) #6

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351643002/20001

4 years, 3 months ago (2016-09-19 10:53:02 UTC) #7

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 3 months ago (2016-09-19 10:54:31 UTC) #8

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/12968) v8_linux_arm64_rel_ng on ...

4 years, 3 months ago (2016-09-19 10:54:32 UTC) #9

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/12968)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/12961)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

petermarshall

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

4 years, 3 months ago (2016-09-19 11:19:07 UTC) #10

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351643002/40001

4 years, 3 months ago (2016-09-19 11:19:11 UTC) #11

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 3 months ago (2016-09-19 11:42:50 UTC) #12

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 3 months ago (2016-09-19 11:42:51 UTC) #13

Dry run: This issue passed the CQ dry run.

petermarshall

petermarshall@chromium.org changed reviewers: + bmeurer@chromium.org, franzih@chromium.org

4 years, 3 months ago (2016-09-19 11:43:05 UTC) #14

petermarshall@chromium.org changed reviewers:
+ bmeurer@chromium.org, franzih@chromium.org

petermarshall

4 years, 3 months ago (2016-09-19 11:43:05 UTC) #15

petermarshall

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

4 years, 3 months ago (2016-09-20 09:04:10 UTC) #16

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351643002/60001

4 years, 3 months ago (2016-09-20 09:04:17 UTC) #17

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 3 months ago (2016-09-20 09:05:45 UTC) #18

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/4570) v8_linux_nodcheck_rel_ng on ...

4 years, 3 months ago (2016-09-20 09:05:46 UTC) #19

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

petermarshall

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

4 years, 3 months ago (2016-09-20 09:26:47 UTC) #20

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351643002/80001

4 years, 3 months ago (2016-09-20 09:26:54 UTC) #21

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 3 months ago (2016-09-20 09:30:04 UTC) #22

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/9192)

4 years, 3 months ago (2016-09-20 09:30:05 UTC) #23

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/9192)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages