Remove old iossim code (pre-Xcode 8) and class-dump.

Remove old iossim code (pre-Xcode 8) and class-dump.

BUG=640559
TBR=brettw

Committed: https://crrev.com/17ca7445f3cd00d605a349152a610b8301b91fba
Cr-Commit-Position: refs/heads/master@{#419962}

[justincohen, 2016-09-19 21:38:12]

The CQ bit was checked by justincohen@chromium.org to run a CQ dry run

[justincohen, 2016-09-19 21:38:24]

justincohen@chromium.org changed reviewers:
+ rohitrao@chromium.org, sdefresne@chromium.org

[justincohen, 2016-09-19 21:38:24]

ptal

[commit-bot: I haz the power, 2016-09-19 21:39:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 00:52:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 00:52:17]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sdefresne, 2016-09-20 08:09:53]

lgtm

https://codereview.chromium.org/2351613006/diff/1/testing/iossim/BUILD.gn
File testing/iossim/BUILD.gn (right):

https://codereview.chromium.org/2351613006/diff/1/testing/iossim/BUILD.gn#new...
testing/iossim/BUILD.gn:16: common_flags = [ "-mmacosx-version-min=10.8" ]
I guess that you tried to compile with 10.7 and that it does not work, right? Is
this due to the use of libc++ or ARC? Can you update the comment to give the
correct reason now that class-dump has been removed.

[justincohen, 2016-09-20 20:55:21]

https://codereview.chromium.org/2351613006/diff/1/testing/iossim/BUILD.gn
File testing/iossim/BUILD.gn (right):

https://codereview.chromium.org/2351613006/diff/1/testing/iossim/BUILD.gn#new...
testing/iossim/BUILD.gn:16: common_flags = [ "-mmacosx-version-min=10.8" ]
On 2016/09/20 08:09:53, sdefresne wrote:
> I guess that you tried to compile with 10.7 and that it does not work, right?
Is
> this due to the use of libc++ or ARC? Can you update the comment to give the
> correct reason now that class-dump has been removed.

Done.

[justincohen, 2016-09-20 20:55:27]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2016-09-20 20:55:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2351613006/#ps20001
(title: "Fix comment")

[commit-bot: I haz the power, 2016-09-20 20:56:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 21:06:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 21:06:51]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rohitrao (ping after 24h), 2016-09-20 21:39:59]

lgtm

[justincohen, 2016-09-20 21:40:12]

The CQ bit was checked by justincohen@chromium.org

[commit-bot: I haz the power, 2016-09-20 21:41:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 21:51:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 21:51:32]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[justincohen, 2016-09-21 03:06:38]

Description was changed from

==========
Remove old iossim code (pre-Xcode 8) and class-dump

BUG=640559
==========

to

==========
Remove old iossim code (pre-Xcode 8) and class-dump

BUG=640559
TBR=brettw
==========

[justincohen, 2016-09-21 03:06:55]

Description was changed from

==========
Remove old iossim code (pre-Xcode 8) and class-dump

BUG=640559
TBR=brettw
==========

to

==========
Remove old iossim code (pre-Xcode 8) and class-dump.

BUG=640559
TBR=brettw
==========

[justincohen, 2016-09-21 03:07:04]

The CQ bit was checked by justincohen@chromium.org

[commit-bot: I haz the power, 2016-09-21 03:07:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 03:14:27]

Description was changed from

==========
Remove old iossim code (pre-Xcode 8) and class-dump.

BUG=640559
TBR=brettw
==========

to

==========
Remove old iossim code (pre-Xcode 8) and class-dump.

BUG=640559
TBR=brettw
==========

[commit-bot: I haz the power, 2016-09-21 03:14:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-21 03:16:53]

Description was changed from

==========
Remove old iossim code (pre-Xcode 8) and class-dump.

BUG=640559
TBR=brettw
==========

to

==========
Remove old iossim code (pre-Xcode 8) and class-dump.

BUG=640559
TBR=brettw

Committed: https://crrev.com/17ca7445f3cd00d605a349152a610b8301b91fba
Cr-Commit-Position: refs/heads/master@{#419962}
==========

[commit-bot: I haz the power, 2016-09-21 03:16:55]

Patchset 2 (id:??) landed as
https://crrev.com/17ca7445f3cd00d605a349152a610b8301b91fba
Cr-Commit-Position: refs/heads/master@{#419962}