Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 23516010: Implement simplistic local alias analysis, which will be used in both check elimination and load el… (Closed)

Created:
7 years, 3 months ago by titzer
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Implement simplistic local alias analysis, which will be used in both check elimination and load elimination. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16645

Patch Set 1 #

Patch Set 2 : Make AliasAnalyzer::MayAlias more conservative and add AliasAnalyzer::ActualValue. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -0 lines) Patch
A src/hydrogen-alias-analysis.h View 1 1 chunk +101 lines, -0 lines 2 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
titzer
7 years, 3 months ago (2013-09-10 14:45:10 UTC) #1
titzer
PTAL, added an ActualValue() method.
7 years, 3 months ago (2013-09-11 08:40:03 UTC) #2
Toon Verwaest
lgtm with nit https://codereview.chromium.org/23516010/diff/4001/src/hydrogen-alias-analysis.h File src/hydrogen-alias-analysis.h (right): https://codereview.chromium.org/23516010/diff/4001/src/hydrogen-alias-analysis.h#newcode40 src/hydrogen-alias-analysis.h:40: }; Can we move this enum ...
7 years, 3 months ago (2013-09-11 09:05:54 UTC) #3
titzer
On 2013/09/11 09:05:54, Toon Verwaest wrote: > lgtm with nit > > https://codereview.chromium.org/23516010/diff/4001/src/hydrogen-alias-analysis.h > File ...
7 years, 3 months ago (2013-09-11 10:47:08 UTC) #4
titzer
Committed patchset #2 manually as r16645 (presubmit successful).
7 years, 3 months ago (2013-09-11 10:54:05 UTC) #5
Michael Starzinger
7 years, 3 months ago (2013-09-12 20:09:08 UTC) #6
Message was sent while issue was closed.
Late DBC that I stumbled over while reviewing load-store elimination.

https://codereview.chromium.org/23516010/diff/4001/src/hydrogen-alias-analysis.h
File src/hydrogen-alias-analysis.h (right):

https://codereview.chromium.org/23516010/diff/4001/src/hydrogen-alias-analysi...
src/hydrogen-alias-analysis.h:90: HValue* ActualValue(HValue* obj) {
Can we move this onto the HValue class? Pretty please! :)

Powered by Google App Engine
This is Rietveld 408576698