Issue 23516004: Have CSSParserContext take a Document reference in argument

Issue 23516004: Have CSSParserContext take a Document reference in argument (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
tkent, dglazkov1

CC:
blink-reviews, devtools-reviews_chromium.org, caseq+blink_chromium.org, gavinp+prerender_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, loislo+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have CSSParserContext take a Document reference in argument Have CSSParserContext take a Document reference in argument instead of a pointer as it can never be NULL. This avoids having to convert a reference into a pointer at the call sites. BUG=281400 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157071

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -27 lines)			Patch
M	Source/core/css/CSSParser.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSParser-in.cpp	View	3 chunks	+10 lines, -10 lines	0 comments	Download
M	Source/core/css/CSSParserMode.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSStyleSheet.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/resolver/StyleBuilderCustom.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Element.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Node.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/ProcessingInstruction.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/SelectorQuery.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/SelectorQuery.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLLinkElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/shadow/HTMLContentElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/InspectorStyleSheet.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/testing/Internals.cpp	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/web/WebDocument.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23516004/1

7 years, 3 months ago (2013-09-02 08:04:00 UTC) #3

Message was sent while issue was closed.

Change committed as 157071

Expand Messages | Collapse Messages