Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 2351593002: [MacViews] Anchor Bookmarks bubble to top-right corner. (Closed)
Patch Set: Addressed review comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
index e3e5e0aabaf991eaf66d8ec428addf06c11f37f2..00aff6bf2f580b6efbe5ae0ea465a391be6fb15b 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
@@ -80,6 +80,10 @@ views::Widget* BookmarkBubbleView::ShowBubble(
bookmark_bubble_ =
new BookmarkBubbleView(anchor_view, observer, std::move(delegate),
profile, url, !already_bookmarked);
+ // Bookmark bubble should always anchor TOP_RIGHT, but the
sky 2016/09/20 02:50:21 If the bookmark bubble should always anchor like y
Eugene But (OOO till 7-30) 2016/09/20 03:11:23 That would feel inconsistent with the code below (
+ // LocationBarBubbleDelegateView does not know that and may use different
+ // arrow anchoring.
+ bookmark_bubble_->set_arrow(views::BubbleBorder::TOP_RIGHT);
if (!anchor_view) {
bookmark_bubble_->SetAnchorRect(anchor_rect);
bookmark_bubble_->set_parent_window(parent_window);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698