Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2351553002: Fix "defined but not used" build error when enable_webrtc=false. (Closed)

Created:
4 years, 3 months ago by Shouqun1
Modified:
4 years, 3 months ago
Reviewers:
Guido Urdaneta, sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix "defined but not used" build error when enable_webrtc=false. BUG= Committed: https://crrev.com/4d122dd4668fbbde8bc66cbd3c2ca6aa79dc0a17 Cr-Commit-Position: refs/heads/master@{#419408}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/renderer_preferences_util.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Shouqun1
PTAL, thanks!
4 years, 3 months ago (2016-09-18 10:09:43 UTC) #2
Guido Urdaneta
lgtm
4 years, 3 months ago (2016-09-18 10:26:39 UTC) #3
sky
LGTM
4 years, 3 months ago (2016-09-18 16:18:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351553002/1
4 years, 3 months ago (2016-09-19 01:12:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 02:08:17 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 02:09:52 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d122dd4668fbbde8bc66cbd3c2ca6aa79dc0a17
Cr-Commit-Position: refs/heads/master@{#419408}

Powered by Google App Engine
This is Rietveld 408576698