Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2351543002: X87: [Interpreter] Adds stackcheck in InterpreterPushArgsAndCall/Construct builtins. (Closed)

Created:
4 years, 3 months ago by zhengxing.li
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Interpreter] Adds stackcheck in InterpreterPushArgsAndCall/Construct builtins. port 7f3d15aad423aabf2f9116a929c8fd750615610a(r39470) original commit message: In ignition, arguments to function calls and function constructors are pushed onto the stack before calling the function. It is required to check that stack does not overflow when pushing the arguments. BUG= Committed: https://crrev.com/2069349377c4082a18d904cbf288d8238d6e2189 Cr-Commit-Position: refs/heads/master@{#39491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -82 lines) Patch
M src/builtins/x87/builtins-x87.cc View 12 chunks +130 lines, -82 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 3 months ago (2016-09-18 07:39:22 UTC) #2
Weiliang
lgtm
4 years, 3 months ago (2016-09-18 07:49:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351543002/1
4 years, 3 months ago (2016-09-18 07:49:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-18 08:08:27 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-18 08:08:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2069349377c4082a18d904cbf288d8238d6e2189
Cr-Commit-Position: refs/heads/master@{#39491}

Powered by Google App Engine
This is Rietveld 408576698