Investigate RelaunchChromeBrowserWithNewCommandLineIfNeeded log spam

Investigate RelaunchChromeBrowserWithNewCommandLineIfNeeded log spam

BUG=648185
Committed: https://crrev.com/c5442858e4f80adbd8afe5dfcfee95b4aba1d487
Cr-Commit-Position: refs/heads/master@{#419889}

[manzagop (departed), 2016-09-19 14:44:21]

manzagop@chromium.org changed reviewers:
+ grt@chromium.org

[manzagop (departed), 2016-09-19 14:44:21]

Please have a look?
Thanks!
Pierre

[grt (UTC plus 2), 2016-09-19 19:59:43]

Thanks for looking at this so quickly!

https://codereview.chromium.org/2351533004/diff/1/chrome/app/chrome_exe_main_...
File chrome/app/chrome_exe_main_win.cc (right):

https://codereview.chromium.org/2351533004/diff/1/chrome/app/chrome_exe_main_...
chrome/app/chrome_exe_main_win.cc:247: if (process_type.empty()) {
it feels cleaner to me for this function to know as little as possible about how
different process types operate. wdyt about putting this logic in MainDllLoader?

[manzagop (departed), 2016-09-20 19:38:24]

Description was changed from

==========
Only attempt a browser relaunch from the browser process

BUG=648185
==========

to

==========
Investigate RelaunchChromeBrowserWithNewCommandLineIfNeeded log spam

BUG=648185
==========

[manzagop (departed), 2016-09-20 19:39:39]

Sorry for the slow turnaround. :( 
As per the discussion on the bug, I switched to simply printing the process
type, since we're not sure which is the cause of the spam.
Another look?
Thank!

https://codereview.chromium.org/2351533004/diff/1/chrome/app/chrome_exe_main_...
File chrome/app/chrome_exe_main_win.cc (right):

https://codereview.chromium.org/2351533004/diff/1/chrome/app/chrome_exe_main_...
chrome/app/chrome_exe_main_win.cc:247: if (process_type.empty()) {
On 2016/09/19 19:59:42, grt (UTC plus 2) wrote:
> it feels cleaner to me for this function to know as little as possible about
how
> different process types operate. wdyt about putting this logic in
MainDllLoader?

Sgtm.

[manzagop (departed), 2016-09-20 19:40:01]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 19:40:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[grt (UTC plus 2), 2016-09-20 20:11:52]

lgtm

[commit-bot: I haz the power, 2016-09-20 21:34:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 21:34:36]

Dry run: This issue passed the CQ dry run.

[manzagop (departed), 2016-09-20 23:02:21]

On 2016/09/20 20:11:52, grt (UTC plus 2) wrote:
> lgtm

Thanks for the review!

[manzagop (departed), 2016-09-20 23:02:27]

The CQ bit was checked by manzagop@chromium.org

[commit-bot: I haz the power, 2016-09-20 23:03:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 23:08:52]

Description was changed from

==========
Investigate RelaunchChromeBrowserWithNewCommandLineIfNeeded log spam

BUG=648185
==========

to

==========
Investigate RelaunchChromeBrowserWithNewCommandLineIfNeeded log spam

BUG=648185
==========

[commit-bot: I haz the power, 2016-09-20 23:08:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-20 23:12:14]

Description was changed from

==========
Investigate RelaunchChromeBrowserWithNewCommandLineIfNeeded log spam

BUG=648185
==========

to

==========
Investigate RelaunchChromeBrowserWithNewCommandLineIfNeeded log spam

BUG=648185

Committed: https://crrev.com/c5442858e4f80adbd8afe5dfcfee95b4aba1d487
Cr-Commit-Position: refs/heads/master@{#419889}
==========

[commit-bot: I haz the power, 2016-09-20 23:12:15]

Patchset 2 (id:??) landed as
https://crrev.com/c5442858e4f80adbd8afe5dfcfee95b4aba1d487
Cr-Commit-Position: refs/heads/master@{#419889}