OLD | NEW |
---|---|
1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 // https://w3c.github.io/browser-payment-api/#paymentoptions-dictionary | 5 // https://w3c.github.io/browser-payment-api/#paymentoptions-dictionary |
6 | 6 |
7 enum PaymentShippingType { | |
8 "shipping", | |
9 "delivery", | |
10 "pickup" | |
11 }; | |
12 | |
7 [ | 13 [ |
8 RuntimeEnabled=PaymentRequest | 14 RuntimeEnabled=PaymentRequest |
9 ] dictionary PaymentOptions { | 15 ] dictionary PaymentOptions { |
10 boolean requestPayerEmail = false; | 16 boolean requestPayerEmail = false; |
11 boolean requestPayerPhone = false; | 17 boolean requestPayerPhone = false; |
12 boolean requestShipping = false; | 18 boolean requestShipping = false; |
19 | |
20 // According to PaymentRequest constructor algorithm 22[1], | |
21 // if options.shippingType is not a valid PaymentShippingType value then | |
22 // set the shippingType attribute on request to 'shipping'. | |
23 // On the other hand, according to webidl spec[2], it causes a TypeError | |
24 // if passing a invalid enum value as operation argument. It means that the | |
25 // constructor can stop due to a exception that occured in binding side. | |
26 // In other words, the former is conflicting with the latter. | |
27 // So, use DOMString instead of PaymentShippingType for now until this | |
28 // spec issue is resolved. Please see: http://crbug.com/648052 | |
29 // | |
30 // [1] https://w3c.github.io/browser-payment-api/#h-note5 | |
31 // [2] http://heycam.github.io/webidl/#example-363ff014 | |
please use gerrit instead
2016/09/20 08:32:16
These comments are no longer necessary. See https:
zino
2016/09/20 15:56:10
Done.
| |
32 DOMString shippingType = "shipping"; | |
13 }; | 33 }; |
OLD | NEW |