Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2813)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/factory.h

Issue 235153003: Handlify code allocation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: fix mips tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins.cc ('k') | src/factory.cc » ('j') | src/heap.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/factory.h
diff --git a/src/factory.h b/src/factory.h
index ae861baa78de18037d41a0ac6fdc40df9ddef6ba..964a592a1fccb9d2ac06ecdb0415ad5638c81dbb 100644
--- a/src/factory.h
+++ b/src/factory.h
@@ -412,6 +412,9 @@ class Factory V8_FINAL {
// Create an External object for V8's external API.
Handle<JSObject> NewExternal(void* value);
+ // The pointer to the Code object is stored in self_reference.
+ // This allows generated code to reference its own Code object
+ // by containing this pointer.
Michael Starzinger 2014/04/16 11:10:04 nit: s/this pointer/this handle/
Yang 2014/04/16 11:29:55 Done.
Handle<Code> NewCode(const CodeDesc& desc,
Code::Flags flags,
Handle<Object> self_reference,
« no previous file with comments | « src/builtins.cc ('k') | src/factory.cc » ('j') | src/heap.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698