Handlify code allocation.

Handlify code allocation.

R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20795

[Yang, 2014-04-15 14:53:31]

On 2014/04/11 13:15:38, Yang wrote:

*creeping up behind your shoulder*

[Michael Starzinger, 2014-04-16 11:10:03]

LGTM, just nits.

https://codereview.chromium.org/235153003/diff/20001/src/factory.h
File src/factory.h (right):

https://codereview.chromium.org/235153003/diff/20001/src/factory.h#newcode417
src/factory.h:417: // by containing this pointer.
nit: s/this pointer/this handle/

https://codereview.chromium.org/235153003/diff/20001/src/mips/assembler-mips.h
File src/mips/assembler-mips.h (left):

https://codereview.chromium.org/235153003/diff/20001/src/mips/assembler-mips....
src/mips/assembler-mips.h:1009: // Allocate a constant pool of the correct size
for the generated code.
nit: Can we get the comment back?

[Michael Starzinger, 2014-04-16 11:25:39]

Comment from offline discussion.

https://codereview.chromium.org/235153003/diff/20001/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/235153003/diff/20001/src/heap.cc#newcode3874
src/heap.cc:3874: code->set_ic_age(global_ic_age_);
As per offline discussion: Let's also move these two initializations into
NewCode, because they are not sufficient to get a consistent view of the heap.
Hence if might be misleading to have the split apart.

[Yang, 2014-04-16 11:29:50]

On 2014/04/16 11:25:39, Michael Starzinger wrote:
> Comment from offline discussion.
> 
> https://codereview.chromium.org/235153003/diff/20001/src/heap.cc
> File src/heap.cc (right):
> 
> https://codereview.chromium.org/235153003/diff/20001/src/heap.cc#newcode3874
> src/heap.cc:3874: code->set_ic_age(global_ic_age_);
> As per offline discussion: Let's also move these two initializations into
> NewCode, because they are not sufficient to get a consistent view of the heap.
> Hence if might be misleading to have the split apart.

addressed comments.

[Yang, 2014-04-16 11:29:54]

https://codereview.chromium.org/235153003/diff/20001/src/factory.h
File src/factory.h (right):

https://codereview.chromium.org/235153003/diff/20001/src/factory.h#newcode417
src/factory.h:417: // by containing this pointer.
On 2014/04/16 11:10:04, Michael Starzinger wrote:
> nit: s/this pointer/this handle/

Done.

https://codereview.chromium.org/235153003/diff/20001/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/235153003/diff/20001/src/heap.cc#newcode3874
src/heap.cc:3874: code->set_ic_age(global_ic_age_);
On 2014/04/16 11:25:39, Michael Starzinger wrote:
> As per offline discussion: Let's also move these two initializations into
> NewCode, because they are not sufficient to get a consistent view of the heap.
> Hence if might be misleading to have the split apart.

Done.

https://codereview.chromium.org/235153003/diff/20001/src/mips/assembler-mips.h
File src/mips/assembler-mips.h (left):

https://codereview.chromium.org/235153003/diff/20001/src/mips/assembler-mips....
src/mips/assembler-mips.h:1009: // Allocate a constant pool of the correct size
for the generated code.
On 2014/04/16 11:10:04, Michael Starzinger wrote:
> nit: Can we get the comment back?

Done.

[Yang, 2014-04-16 11:39:27]

Committed patchset #3 manually as r20795 (presubmit successful).